| Summary: | Remove view source code | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Anders Carlsson <andersca> | ||||||||
| Component: | New Bugs | Assignee: | Anders Carlsson <andersca> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | allan.jensen, berto, bunhere, commit-queue, esprehn+autocc, glenn, gyuyoung.kim, gyuyoung.kim, japhet, kangil.han, macpherson, menard, rakuco, sergio, zan | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 128945 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Anders Carlsson
2014-01-18 13:27:26 PST
Created attachment 221567 [details]
Patch
Created attachment 221568 [details]
Patch
I'm going to hold off doing this until we've found a solution for the GTK+ port which exposes this as API. Created attachment 224431 [details]
Patch
Comment on attachment 224431 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=224431&action=review > Source/WebCore/css/DocumentRuleSets.cpp:103 > -void DocumentRuleSets::collectFeatures(bool isViewSource) > +void DocumentRuleSets::collectFeatures() Nice! Committed r164254: <http://trac.webkit.org/changeset/164254> EFL port has been broken since r164254. Coordinated Graphics is still using setMainFrameInViewSourceMode() and mainFrameInViewSourceMode(). Any reason to remove it ? http://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/12942 (In reply to comment #7) > EFL port has been broken since r164254. Coordinated Graphics is still using setMainFrameInViewSourceMode() and mainFrameInViewSourceMode(). Any reason to remove it ? > > http://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/12942 I'm sorry, I was unaware that the EFL port also used this API! We're removing it for the reasons described in a previous WebKitGTK+ ChangeLog: This is a first step towards getting rid of the view source mode from WebCore. View source shouldn't be a mode on the web page and can be implemented in other ways by embedding apps. Furthermore, the inspector has an excellent view source mode. |