| Summary: | [CodeGeneratorJS] Sort output of StructureFlags and function parameters | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alberto Garcia <berto> | ||||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | alecflett, cdumez, cgarcia, commit-queue, eric.carlson, glenn, jer.noble, jsbell | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
Created attachment 221557 [details]
Patch
This also affects function parameters, I'll update the patch. Created attachment 221560 [details]
Patch
Committed r162280: <http://trac.webkit.org/changeset/162280> |
We're using the following code to create StructureFlags: foreach my $structureFlag (keys %structureFlags) { push(@headerContent, $structureFlag . " | "); } The problem is that keys %structureFlags returns a list in an unspecified order, which can change between Perl versions and is indeed making the bindings tests fail in one of the GTK+ bots: PASS: (JS) JSTestException.cpp FAIL: (JS) JSTestException.h --- WebCore/bindings/scripts/test/JS/JSTestException.h 2014-01-17 06:05:06.759471284 -0800 +++ /tmp/tmpGfPzJ5/JSTestException.h 2014-01-18 01:22:50.056392293 -0800 @@ -67,7 +67,7 @@ protected: JSTestException(JSC::Structure*, JSDOMGlobalObject*, PassRefPtr<TestException>); void finishCreation(JSC::VM&); - static const unsigned StructureFlags = JSC::OverridesGetOwnPropertySlot | JSC::InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero | Base::StructureFlags; + static const unsigned StructureFlags = JSC::InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero | JSC::OverridesGetOwnPropertySlot | Base::StructureFlags; }; class JSTestExceptionOwner : public JSC::WeakHandleOwner {