Bug 127221

Summary:

Remove DocumentParser::pinToMainThread() and related code

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, esprehn+autocc, gyuyoung.kim, japhet, kangil.han

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	kling: review+

Description Anders Carlsson 2014-01-18 09:00:39 PST

Remove DocumentParser::pinToMainThread() and related code

Comment 1 Anders Carlsson 2014-01-18 09:01:07 PST

Created attachment 221552 [details]
Patch

Comment 2 Andreas Kling 2014-01-18 09:06:21 PST

Comment on attachment 221552 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221552&action=review

r=me

> Source/WebCore/dom/DocumentParser.h:-53
> -    virtual void pinToMainThread() { }

Stupid that we always ate this virtual in unthreaded builds.

> Source/WebCore/html/parser/HTMLDocumentParser.cpp:74
> +    , m_tokenizer(HTMLTokenizer::create(m_options))

Maybe this doesn't need to be heap allocated anymore.

> Source/WebCore/html/parser/HTMLDocumentParser.cpp:88
> -    ASSERT(shouldUseThreading() || (m_token && m_tokenizer));
> +    ASSERT(m_token);
> +    ASSERT(m_tokenizer);

I guess we shouldn't even really need these assertions in the end.

Comment 3 Anders Carlsson 2014-01-18 09:07:29 PST

Committed r162254: <http://trac.webkit.org/changeset/162254>