Bug 127221

Summary: Remove DocumentParser::pinToMainThread() and related code
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, gyuyoung.kim, japhet, kangil.han
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch kling: review+

Anders Carlsson
Reported 2014-01-18 09:00:39 PST
Remove DocumentParser::pinToMainThread() and related code
Attachments
Patch (10.52 KB, patch)
2014-01-18 09:01 PST, Anders Carlsson 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2014-01-18 09:01:07 PST
Created attachment 221552 [details] Patch
Andreas Kling
Comment 2 2014-01-18 09:06:21 PST
Comment on attachment 221552 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=221552&action=review r=me > Source/WebCore/dom/DocumentParser.h:-53 > - virtual void pinToMainThread() { } Stupid that we always ate this virtual in unthreaded builds. > Source/WebCore/html/parser/HTMLDocumentParser.cpp:74 > + , m_tokenizer(HTMLTokenizer::create(m_options)) Maybe this doesn't need to be heap allocated anymore. > Source/WebCore/html/parser/HTMLDocumentParser.cpp:88 > - ASSERT(shouldUseThreading() || (m_token && m_tokenizer)); > + ASSERT(m_token); > + ASSERT(m_tokenizer); I guess we shouldn't even really need these assertions in the end.
Anders Carlsson
Comment 3 2014-01-18 09:07:29 PST
Committed r162254: <http://trac.webkit.org/changeset/162254>
Note You need to log in before you can comment on or make changes to this bug.