Bug 127218

Summary: Replace a couple of uses of WTF::Function with std::function
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, commit-queue, jamesr, luiz, tonikitoo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch kling: review+

Anders Carlsson
Reported 2014-01-18 07:30:14 PST
Replace a couple of uses of WTF::Function with std::function
Attachments
Patch (17.94 KB, patch)
2014-01-18 07:35 PST, Anders Carlsson 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2014-01-18 07:35:09 PST
Created attachment 221547 [details] Patch
WebKit Commit Bot
Comment 2 2014-01-18 07:37:45 PST
Attachment 221547 [details] did not pass style-queue: ERROR: Source/WebKit2/WebProcess/WebPage/DrawingArea.h:112: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/page/scrolling/ScrollingThread.cpp:49: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/page/scrolling/ScrollingThread.cpp:61: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/page/scrolling/ScrollingThread.cpp:63: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/scrolling/ScrollingThread.cpp:87: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/page/scrolling/ScrollingThread.cpp:87: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/page/scrolling/ScrollingThread.cpp:106: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/WebPage/DrawingArea.cpp:80: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Shared/ChildProcess.cpp:53: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/Platform/WorkQueue.h:60: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Platform/WorkQueue.h:61: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/page/scrolling/ScrollingThread.h:49: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/page/scrolling/ScrollingThread.h:53: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/page/scrolling/ScrollingThread.h:81: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Platform/mac/WorkQueueMac.cpp:29: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Platform/mac/WorkQueueMac.cpp:38: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Platform/mac/WorkQueueMac.cpp:41: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:87: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Platform/IPC/mac/ConnectionMac.cpp:104: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Platform/IPC/mac/ConnectionMac.cpp:107: Missing space before { [whitespace/braces] [5] Total errors found: 20 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andreas Kling
Comment 3 2014-01-18 14:51:02 PST
Comment on attachment 221547 [details] Patch r=me
Anders Carlsson
Comment 4 2014-01-18 14:56:04 PST
Committed r162276: <http://trac.webkit.org/changeset/162276>
Note You need to log in before you can comment on or make changes to this bug.