Bug 127218

Summary:

Replace a couple of uses of WTF::Function with std::function

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cmarcelo, commit-queue, jamesr, luiz, tonikitoo

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	kling: review+

Description Anders Carlsson 2014-01-18 07:30:14 PST

Replace a couple of uses of WTF::Function with std::function

Comment 1 Anders Carlsson 2014-01-18 07:35:09 PST

Created attachment 221547 [details]
Patch

Comment 2 WebKit Commit Bot 2014-01-18 07:37:45 PST

Attachment 221547 [details] did not pass style-queue:


ERROR: Source/WebKit2/WebProcess/WebPage/DrawingArea.h:112:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/page/scrolling/ScrollingThread.cpp:49:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/page/scrolling/ScrollingThread.cpp:61:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/page/scrolling/ScrollingThread.cpp:63:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebCore/page/scrolling/ScrollingThread.cpp:87:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebCore/page/scrolling/ScrollingThread.cpp:87:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebCore/page/scrolling/ScrollingThread.cpp:106:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/WebProcess/WebPage/DrawingArea.cpp:80:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/Shared/ChildProcess.cpp:53:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebKit2/Platform/WorkQueue.h:60:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/Platform/WorkQueue.h:61:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/page/scrolling/ScrollingThread.h:49:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/page/scrolling/ScrollingThread.h:53:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/page/scrolling/ScrollingThread.h:81:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/Platform/mac/WorkQueueMac.cpp:29:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/Platform/mac/WorkQueueMac.cpp:38:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/Platform/mac/WorkQueueMac.cpp:41:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:87:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/Platform/IPC/mac/ConnectionMac.cpp:104:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/Platform/IPC/mac/ConnectionMac.cpp:107:  Missing space before {  [whitespace/braces] [5]
Total errors found: 20 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Andreas Kling 2014-01-18 14:51:02 PST

Comment on attachment 221547 [details]
Patch

r=me

Comment 4 Anders Carlsson 2014-01-18 14:56:04 PST

Committed r162276: <http://trac.webkit.org/changeset/162276>