Bug 127203
| Summary: | EWS should immediately notify patch authors about failures (and maybe when everything is green too) | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED CONFIGURATION CHANGED | ||
| Severity: | Normal | CC: | aakash_jain, ahmad.saleem792, dbates, mitz, rniwa, ryanhaddad, sam |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Alexey Proskuryakov
It's a huge waste of time that you are no longer informed when a build fails on EWS. This seriously delays urgent work, as you only start working on fixes when you happen to manually poll, or even worse, when a reviewer tells you to.
It's good to not spam everyone, but patch author should be notified by EWS immediately I think. Some ideas:
- e-mail;
- IRC;
- browser notifications when bug page is open.
The latter might be best, as it also gives some control over whether to get pinged - keep the bug open if you care, close it if it's not urgent, and you cannot afford distraction now.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Sam Weinig
If we do this, it should be opt-in. At least in my workflow, this would be more annoying than helpful.
Ahmad Saleem
I think it is partially implemented already in EWS as of today:
-> Build fails - Email (need to be in Contributors.json - if I am not wrong)
-> Test fails - Email
__
Do we need to enhance it with `notifications` or make it more streamlined etc., I think we can raise new bug with new ideas or we might even have it already.
Should we close this? @Alexey
Alexey Proskuryakov
I think so too, but I almost never post PRs that can break the build at this point, and don't have hands-on experience. Adding Aakash and Ryan who would have the most insight.