| Summary: | Unprefix text-decoration CSS3 properties | ||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||||||||||||||||||||
| Component: | New Bugs | Assignee: | Myles C. Maxfield <mmaxfield> | ||||||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||||||
| Severity: | Normal | CC: | allan.jensen, brunoabinader, buildbot, bunhere, cdumez, commit-queue, dino, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jonlee, kondapallykalyan, macpherson, menard, rakuco, rniwa, sam, simon.fraser, syoichi, thorton, webkit-bug-importer, zcorpan | ||||||||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||||||
| Bug Depends on: | 127333 | ||||||||||||||||||||||||
| Bug Blocks: | |||||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||||
|
Description
Myles C. Maxfield
2014-01-17 15:25:39 PST
Created attachment 221507 [details]
Patch
Comment on attachment 221507 [details] Patch Attachment 221507 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4835051447517184 New failing tests: editing/style/remove-underline-across-paragraph-in-bold.html editing/execCommand/5190926.html editing/style/inline-style-extend-run.html editing/deleting/delete-line-break-before-underlined-content.html editing/deleting/merge-div-from-span-with-style.html editing/style/remove-nested-inline-styles.html editing/style/push-down-implicit-styles-around-list-mac.html editing/style/inline-style-container.html editing/execCommand/strikethroughSelection.html editing/pasteboard/insert-u-with-text-decoration-none.html editing/execCommand/toggle-style-2.html editing/pasteboard/5134759.html editing/style/push-down-implicit-styles-around-list-win.html editing/execCommand/remove-format-multiple-elements-win.html editing/style/remove-underline-across-paragraph.html editing/deleting/merge-paragraph-from-span-with-multiple-text-decoration.html editing/style/font-family-with-space.html editing/style/push-down-implicit-styles-mac.html editing/pasteboard/5075944.html editing/execCommand/remove-format-multiple-elements-mac.html editing/execCommand/toggle-styles.html editing/execCommand/query-text-decoration-with-typing-style.html editing/execCommand/inline-style-after-indentoutdent.html editing/execCommand/toggle-text-decorations.html editing/execCommand/use-css.html editing/deleting/merge-paragraph-from-span-with-style.html editing/style/push-down-inline-styles.html editing/execCommand/strikethrough-uses-strike-tag.html editing/deleting/deleting-line-break-preserves-underline-color.html editing/execCommand/remove-formatting.html Created attachment 221513 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 221507 [details] Patch Attachment 221507 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6096580314660864 New failing tests: editing/style/remove-underline-across-paragraph-in-bold.html editing/execCommand/5190926.html editing/style/inline-style-extend-run.html editing/deleting/delete-line-break-before-underlined-content.html editing/deleting/merge-div-from-span-with-style.html editing/style/remove-nested-inline-styles.html editing/style/push-down-implicit-styles-around-list-mac.html editing/style/inline-style-container.html editing/execCommand/strikethroughSelection.html editing/pasteboard/insert-u-with-text-decoration-none.html editing/execCommand/toggle-style-2.html editing/pasteboard/5134759.html editing/style/push-down-implicit-styles-around-list-win.html editing/execCommand/remove-format-multiple-elements-win.html editing/style/remove-underline-across-paragraph.html editing/deleting/merge-paragraph-from-span-with-multiple-text-decoration.html editing/style/font-family-with-space.html editing/style/push-down-implicit-styles-mac.html editing/pasteboard/5075944.html editing/execCommand/remove-format-multiple-elements-mac.html editing/execCommand/toggle-styles.html editing/execCommand/query-text-decoration-with-typing-style.html editing/style/remove-underline-after-paragraph-in-bold.html editing/execCommand/inline-style-after-indentoutdent.html editing/execCommand/toggle-text-decorations.html editing/deleting/merge-paragraph-from-span-with-style.html editing/style/push-down-inline-styles.html editing/execCommand/strikethrough-uses-strike-tag.html editing/deleting/deleting-line-break-preserves-underline-color.html editing/execCommand/remove-formatting.html Created attachment 221520 [details]
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-06 Port: mac-mountainlion Platform: Mac OS X 10.8.5
If we are truly ready to un-prefix these (and I am not sure we are), we should probably first remove the #ifdefs. *** Bug 123657 has been marked as a duplicate of this bug. *** Created attachment 221775 [details]
Patch
The Radar assigned here conflicts with 127333. Whoops, marked wrong bug If we're unprefixing text-decoration CSS properties, we should unprefix all of the text-decoration CSS properties. WHATWG's standard.css now uses text-decoration-color (sans prefix), see https://github.com/whatwg/resources.whatwg.org/pull/45 Looks like text-decoration and -webkit-text-decoration are distinct properties, with different semantics??? :( Created attachment 354039 [details]
Patch
Comment on attachment 354039 [details] Patch Attachment 354039 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9888376 New failing tests: imported/w3c/web-platform-tests/css/mediaqueries/test_media_queries.html imported/blink/fast/css3-text/css3-text-decoration/text-decoration-line-recalc.html imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-line-recalc.html Created attachment 354056 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 354039 [details] Patch Attachment 354039 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/9888296 New failing tests: imported/w3c/web-platform-tests/css/mediaqueries/test_media_queries.html imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-line-recalc.html imported/blink/fast/css3-text/css3-text-decoration/text-decoration-line-recalc.html Created attachment 354058 [details]
Archive of layout-test-results from ews113 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 354039 [details] Patch Attachment 354039 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/9888981 New failing tests: imported/blink/fast/css3-text/css3-text-decoration/text-decoration-line-recalc.html Created attachment 354060 [details]
Archive of layout-test-results from ews201 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews201 Port: win-future Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit
Comment on attachment 354039 [details] Patch Attachment 354039 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/9889116 New failing tests: imported/w3c/web-platform-tests/css/mediaqueries/test_media_queries.html imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-line-recalc.html imported/blink/fast/css3-text/css3-text-decoration/text-decoration-line-recalc.html Created attachment 354062 [details]
Archive of layout-test-results from ews102 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 354039 [details] Patch Attachment 354039 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/9890024 New failing tests: imported/w3c/web-platform-tests/css/mediaqueries/test_media_queries.html imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-line-recalc.html imported/blink/fast/css3-text/css3-text-decoration/text-decoration-line-recalc.html Created attachment 354067 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Committed r238002: <https://trac.webkit.org/changeset/238002> |