[GTK] Add GUniquePtr

• Component: Web Template Framework
• Status: RESOLVED FIXED

[Carlos Garcia Campos]

The idea is to replace GOwnPtr with a new simpler class derived the std:unique_ptr. Not everything can be replaced, though, because GOwnPtr::outPtr() doesn't seem to be possible to implement with unique_ptr.

[Carlos Garcia Campos]

Created attachment 221454 [details]
Patch

This is a first patch adding support for glib types already supported by GOwnPtr, except GError that is usually used with GOwnPtr::outPtr(). Then, adding support for Soup and GTK/GDK types would be a matter of defining a macro  FOR_EACH_SOUP_DELETER, FOR_EACH_GDK_DELETER, etc and call it with DEFINE_DELETER. I'll also start porting existing code to GUniquePtr once/if this patch lands.

[Carlos Garcia Campos]

Created attachment 221457 [details]
Updated patch

Undef the FOR_EACH_GLIB_DELETER after using it.

[Carlos Garcia Campos]

Created attachment 221458 [details]
Updated patch

Forgot to git add the tests makefile changes.

[Carlos Garcia Campos]

Created attachment 221461 [details]
Updated patch

Simply made the operator() of the deleters const.

[Carlos Garcia Campos]

Created attachment 221470 [details]
Even simpler patch using template alias

This is even simpler now using a template alias as suggested in bug #126255

[Carlos Garcia Campos]

Created attachment 221754 [details]
Updated patch

Added deleter for GError and prefixed the DEFINE_DELETER macro with WTF since it's public macro to be used by others.

[Gustavo Noronha (kov)]

Comment on attachment 221754 [details]
Updated patch

LGTM, pitty we can't extend std::unique_ptr, but then again, not sure how sane that would be.

[Carlos Garcia Campos]

Committed r162516: <http://trac.webkit.org/changeset/162516>

[Zan Dobersek]

*** Bug 126255 has been marked as a duplicate of this bug. ***