Bug 127155

Summary:

Eliminate {push,pop}CalleeSaves in favor of individual pushes & pops

Product:

WebKit

Reporter:

Michael Saboff <msaboff>

Component:

JavaScriptCore

Assignee:

Michael Saboff <msaboff>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	ggaren: review+

Description Michael Saboff 2014-01-16 17:28:33 PST

pushCalleeSaves and popCalleeSaves are pseudo ops in the low level assembler.  As such, the registers are not visible where these pseudo ops are used.  These pseudo ops should be eliminated and replaced with explicit pushes and pops.

Comment 1 Michael Saboff 2014-08-11 13:56:46 PDT

Created attachment 236398 [details]
Patch

Comment 2 Geoffrey Garen 2014-08-11 16:11:21 PDT

Comment on attachment 236398 [details]
Patch

Seems reasonable.

We should be careful not to use "emit" in too many places. This is one good place for it.

Comment 3 Michael Saboff 2014-08-11 19:32:50 PDT

(In reply to comment #2)
> (From update of attachment 236398 [details])
> Seems reasonable.
> 
> We should be careful not to use "emit" in too many places. This is one good place for it.

I agree.  Currently I don't have any other uses in mind.

Comment 4 Michael Saboff 2014-08-11 20:20:26 PDT

Committed r172429: <http://trac.webkit.org/changeset/172429>