Summary: | REGRESSION(r162145): media/video-controls-visible-audio-only.html fails | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||||||||
Component: | Media | Assignee: | Jer Noble <jer.noble> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | commit-queue, eric.carlson, glenn, jer.noble | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Alexey Proskuryakov
2014-01-16 14:53:10 PST
Added the test to TestExpectations in <http://trac.webkit.org/r162157>. Since this change introduced a strange and (yet) inexplicable dependency between tests, and media test failures are by far the #1 contributor to testing instability, my plan is to roll out r162145 later today if fixing it for good proves difficult. Created attachment 221422 [details]
Patch
Created attachment 221424 [details]
Patch
Now with a re-enabled test.
Comment on attachment 221424 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=221424&action=review > Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.h:45 > + virtual void resetRestrictions() OVERRIDE; This won't build, as we don't have OVERRIDE any more. Please use lower case now. Created attachment 221425 [details]
Patch for landing
Created attachment 221428 [details]
Patch for landing
Rebaselined
Comment on attachment 221428 [details] Patch for landing Rejecting attachment 221428 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 221428, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in LayoutTests/ChangeLog contains OOPS!. Full output: http://webkit-queues.appspot.com/results/5734015281659904 Committed r162178: <http://trac.webkit.org/changeset/162178> |