Summary: | Web Inspector: Improve TimelineOverview by not putting TimelineRuler in a scroll area | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Timothy Hatcher <timothy> | ||||
Component: | Web Inspector | Assignee: | Timothy Hatcher <timothy> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | graouts, joepeck, timothy, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Timothy Hatcher
2014-01-16 14:43:51 PST
Created attachment 221417 [details]
Patch
Comment on attachment 221417 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=221417&action=review r=me > Source/WebInspectorUI/UserInterface/TimelineOverview.js:178 > + this.scrollStartTime = marker.time - (this.visibleDuration / 2); Maybe in the future we can be a bit smarter here and reveal the entire marker if it fits in the overview with some padding. Currently this attempts to center the marker? That sounds like a good default. > Source/WebInspectorUI/UserInterface/TimelineOverview.js:266 > + if (Math.abs(event.deltaX) >= Math.abs(event.deltaY) * 0.5) { > + // Clone the event to dispatch it on the scroll container. Mark it as cloned so we don't get into a loop. > + var newWheelEvent = new event.constructor(event.type, event); > + newWheelEvent.__cloned = true; Clever! Comment on attachment 221417 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=221417&action=review >> Source/WebInspectorUI/UserInterface/TimelineOverview.js:178 >> + this.scrollStartTime = marker.time - (this.visibleDuration / 2); > > Maybe in the future we can be a bit smarter here and reveal the entire marker if it fits in the overview with some padding. Currently this attempts to center the marker? That sounds like a good default. Yeah it tries to center. In practice it is on;y used for the current time marker, and that pins to the right because it is always the end time. |