Change all uses of FINAL to final now that all our compilers support it

• Component: New Bugs
• Status: RESOLVED FIXED

[Anders Carlsson]

Change all uses of FINAL to final now that all our compilers support it

[Anders Carlsson]

Created attachment 221414 [details]
Patch

[WebKit Commit Bot]

Attachment 221414 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/inspector/JSGlobalObjectInspectorController.h', u'Source/JavaScriptCore/inspector/agents/InspectorAgent.h', u'Source/JavaScriptCore/inspector/remote/RemoteInspector.h', u'Source/JavaScriptCore/inspector/remote/RemoteInspectorDebuggableConnection.h', u'Source/JavaScriptCore/inspector/scripts/CodeGeneratorInspector.py', u'Source/JavaScriptCore/runtime/JSGlobalObjectDebuggable.h', u'Source/JavaScriptCore/runtime/JSPromiseReaction.cpp', u'Source/WebCore/ChangeLog', u'Source/WebCore/Modules/encryptedmedia/MediaKeySession.h', u'Source/WebCore/Modules/indexeddb/IDBCursorBackendOperations.h', u'Source/WebCore/Modules/indexeddb/IDBDatabase.h', u'Source/WebCore/Modules/indexeddb/IDBDatabaseCallbacksImpl.h', u'Source/WebCore/Modules/indexeddb/IDBRequest.h', u'Source/WebCore/Modules/indexeddb/IDBTransaction.h', u'Source/WebCore/Modules/indexeddb/IDBTransactionBackendOperations.h', u'Source/WebCore/Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp', u'Source/WebCore/Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.h', u'Source/WebCore/Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.h', u'Source/WebCore/Modules/mediasource/MediaSource.h', u'Source/WebCore/Modules/mediasource/MediaSourceRegistry.h', u'Source/WebCore/Modules/mediasource/SourceBuffer.h', u'Source/WebCore/Modules/mediasource/SourceBufferList.h', u'Source/WebCore/Modules/mediastream/AudioStreamTrack.h', u'Source/WebCore/Modules/mediastream/MediaStream.h', u'Source/WebCore/Modules/mediastream/MediaStreamRegistry.h', u'Source/WebCore/Modules/mediastream/MediaStreamTrack.h', u'Source/WebCore/Modules/mediastream/RTCDTMFSender.h', u'Source/WebCore/Modules/mediastream/RTCDataChannel.h', u'Source/WebCore/Modules/mediastream/RTCPeerConnection.h', u'Source/WebCore/Modules/mediastream/UserMediaRequest.h', u'Source/WebCore/Modules/mediastream/VideoStreamTrack.h', u'Source/WebCore/Modules/notifications/Notification.h', u'Source/WebCore/Modules/speech/SpeechSynthesisUtterance.h', u'Source/WebCore/Modules/webaudio/AudioContext.h', u'Source/WebCore/Modules/webaudio/AudioNode.h', u'Source/WebCore/Modules/websockets/WebSocket.h', u'Source/WebCore/accessibility/AccessibilityList.h', u'Source/WebCore/accessibility/AccessibilityListBoxOption.h', u'Source/WebCore/accessibility/AccessibilityNodeObject.h', u'Source/WebCore/accessibility/AccessibilitySearchFieldButtons.h', u'Source/WebCore/accessibility/AccessibilitySlider.h', u'Source/WebCore/bindings/js/JSCryptoAlgorithmBuilder.h', u'Source/WebCore/bindings/js/JSCryptoKeySerializationJWK.h', u'Source/WebCore/bindings/js/JSDOMGlobalObjectTask.cpp', u'Source/WebCore/bindings/js/JSDOMGlobalObjectTask.h', u'Source/WebCore/bindings/js/JSLazyEventListener.h', u'Source/WebCore/bindings/js/ScriptDebugServer.h', u'Source/WebCore/bindings/js/WorkerScriptDebugServer.h', u'Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CBC.h', u'Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_KW.h', u'Source/WebCore/crypto/algorithms/CryptoAlgorithmHMAC.h', u'Source/WebCore/crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.h', u'Source/WebCore/crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.h', u'Source/WebCore/crypto/algorithms/CryptoAlgorithmRSA_OAEP.h', u'Source/WebCore/crypto/algorithms/CryptoAlgorithmSHA1.h', u'Source/WebCore/crypto/algorithms/CryptoAlgorithmSHA224.h', u'Source/WebCore/crypto/algorithms/CryptoAlgorithmSHA256.h', u'Source/WebCore/crypto/algorithms/CryptoAlgorithmSHA384.h', u'Source/WebCore/crypto/algorithms/CryptoAlgorithmSHA512.h', u'Source/WebCore/crypto/keys/CryptoKeyAES.h', u'Source/WebCore/crypto/keys/CryptoKeyDataOctetSequence.h', u'Source/WebCore/crypto/keys/CryptoKeyDataRSAComponents.h', u'Source/WebCore/crypto/keys/CryptoKeyHMAC.h', u'Source/WebCore/crypto/keys/CryptoKeyRSA.h', u'Source/WebCore/crypto/keys/CryptoKeySerializationRaw.h', u'Source/WebCore/crypto/parameters/CryptoAlgorithmAesCbcParams.h', u'Source/WebCore/crypto/parameters/CryptoAlgorithmAesKeyGenParams.h', u'Source/WebCore/crypto/parameters/CryptoAlgorithmHmacKeyParams.h', u'Source/WebCore/crypto/parameters/CryptoAlgorithmHmacParams.h', u'Source/WebCore/crypto/parameters/CryptoAlgorithmRsaKeyGenParams.h', u'Source/WebCore/crypto/parameters/CryptoAlgorithmRsaKeyParamsWithHash.h', u'Source/WebCore/crypto/parameters/CryptoAlgorithmRsaOaepParams.h', u'Source/WebCore/crypto/parameters/CryptoAlgorithmRsaSsaParams.h', u'Source/WebCore/css/CSSCanvasValue.h', u'Source/WebCore/css/CSSFontSelector.h', u'Source/WebCore/css/CSSStyleSheet.h', u'Source/WebCore/dom/Attr.h', u'Source/WebCore/dom/BeforeUnloadEvent.h', u'Source/WebCore/dom/CDATASection.h', u'Source/WebCore/dom/CharacterData.h', u'Source/WebCore/dom/ChildNodeList.h', u'Source/WebCore/dom/Clipboard.cpp', u'Source/WebCore/dom/Comment.h', u'Source/WebCore/dom/DatasetDOMStringMap.h', u'Source/WebCore/dom/Document.h', u'Source/WebCore/dom/DocumentEventQueue.cpp', u'Source/WebCore/dom/DocumentEventQueue.h', u'Source/WebCore/dom/DocumentType.h', u'Source/WebCore/dom/Element.h', u'Source/WebCore/dom/EntityReference.h', u'Source/WebCore/dom/EventContext.h', u'Source/WebCore/dom/EventTarget.h', u'Source/WebCore/dom/FocusEvent.h', u'Source/WebCore/dom/LiveNodeList.h', u'Source/WebCore/dom/MessagePort.h', u'Source/WebCore/dom/MouseEvent.h', u'Source/WebCore/dom/Node.h', u'Source/WebCore/dom/Notation.h', u'Source/WebCore/dom/ProcessingInstruction.h', u'Source/WebCore/dom/PseudoElement.h', u'Source/WebCore/dom/ShadowRoot.h', u'Source/WebCore/dom/StaticNodeList.h', u'Source/WebCore/dom/StyledElement.h', u'Source/WebCore/dom/TemplateContentDocumentFragment.h', u'Source/WebCore/dom/Text.h', u'Source/WebCore/dom/WebKitNamedFlow.h', u'Source/WebCore/editing/ios/EditorIOS.mm', u'Source/WebCore/editing/mac/EditorMac.mm', u'Source/WebCore/editing/markup.cpp', u'Source/WebCore/fileapi/Blob.cpp', u'Source/WebCore/fileapi/FileReader.h', u'Source/WebCore/html/ClassList.h', u'Source/WebCore/html/DOMSettableTokenList.h', u'Source/WebCore/html/FTPDirectoryDocument.cpp', u'Source/WebCore/html/FormAssociatedElement.cpp', u'Source/WebCore/html/FormAssociatedElement.h', u'Source/WebCore/html/HTMLAllCollection.h', u'Source/WebCore/html/HTMLAnchorElement.h', u'Source/WebCore/html/HTMLAppletElement.h', u'Source/WebCore/html/HTMLAreaElement.h', u'Source/WebCore/html/HTMLAudioElement.h', u'Source/WebCore/html/HTMLBDIElement.h', u'Source/WebCore/html/HTMLBRElement.h', u'Source/WebCore/html/HTMLBaseElement.h', u'Source/WebCore/html/HTMLBaseFontElement.h', u'Source/WebCore/html/HTMLBodyElement.h', u'Source/WebCore/html/HTMLButtonElement.h', u'Source/WebCore/html/HTMLCanvasElement.h', u'Source/WebCore/html/HTMLDListElement.h', u'Source/WebCore/html/HTMLDataListElement.h', u'Source/WebCore/html/HTMLDetailsElement.h', u'Source/WebCore/html/HTMLDirectoryElement.h', u'Source/WebCore/html/HTMLDocument.h', u'Source/WebCore/html/HTMLElement.h', u'Source/WebCore/html/HTMLEmbedElement.h', u'Source/WebCore/html/HTMLFieldSetElement.h', u'Source/WebCore/html/HTMLFontElement.h', u'Source/WebCore/html/HTMLFormControlElement.h', u'Source/WebCore/html/HTMLFormElement.h', u'Source/WebCore/html/HTMLFrameElement.h', u'Source/WebCore/html/HTMLFrameSetElement.h', u'Source/WebCore/html/HTMLHRElement.h', u'Source/WebCore/html/HTMLHeadElement.h', u'Source/WebCore/html/HTMLHeadingElement.h', u'Source/WebCore/html/HTMLHtmlElement.h', u'Source/WebCore/html/HTMLIFrameElement.h', u'Source/WebCore/html/HTMLImageElement.h', u'Source/WebCore/html/HTMLInputElement.h', u'Source/WebCore/html/HTMLKeygenElement.cpp', u'Source/WebCore/html/HTMLKeygenElement.h', u'Source/WebCore/html/HTMLLIElement.h', u'Source/WebCore/html/HTMLLabelElement.h', u'Source/WebCore/html/HTMLLegendElement.h', u'Source/WebCore/html/HTMLLinkElement.h', u'Source/WebCore/html/HTMLMapElement.h', u'Source/WebCore/html/HTMLMarqueeElement.h', u'Source/WebCore/html/HTMLMenuElement.h', u'Source/WebCore/html/HTMLMetaElement.h', u'Source/WebCore/html/HTMLMeterElement.h', u'Source/WebCore/html/HTMLModElement.h', u'Source/WebCore/html/HTMLNameCollection.h', u'Source/WebCore/html/HTMLOListElement.h', u'Source/WebCore/html/HTMLObjectElement.h', u'Source/WebCore/html/HTMLOptGroupElement.h', u'Source/WebCore/html/HTMLOptionElement.h', u'Source/WebCore/html/HTMLOptionsCollection.h', u'Source/WebCore/html/HTMLOutputElement.h', u'Source/WebCore/html/HTMLParagraphElement.h', u'Source/WebCore/html/HTMLParamElement.h', u'Source/WebCore/html/HTMLPlugInElement.h', u'Source/WebCore/html/HTMLPreElement.h', u'Source/WebCore/html/HTMLProgressElement.h', u'Source/WebCore/html/HTMLQuoteElement.h', u'Source/WebCore/html/HTMLScriptElement.h', u'Source/WebCore/html/HTMLSelectElement.h', u'Source/WebCore/html/HTMLSourceElement.h', u'Source/WebCore/html/HTMLStyleElement.h', u'Source/WebCore/html/HTMLSummaryElement.h', u'Source/WebCore/html/HTMLTableCaptionElement.h', u'Source/WebCore/html/HTMLTableCellElement.h', u'Source/WebCore/html/HTMLTableColElement.h', u'Source/WebCore/html/HTMLTableElement.h', u'Source/WebCore/html/HTMLTableRowElement.h', u'Source/WebCore/html/HTMLTableRowsCollection.h', u'Source/WebCore/html/HTMLTableSectionElement.h', u'Source/WebCore/html/HTMLTemplateElement.h', u'Source/WebCore/html/HTMLTextAreaElement.h', u'Source/WebCore/html/HTMLTextFormControlElement.h', u'Source/WebCore/html/HTMLTitleElement.h', u'Source/WebCore/html/HTMLTrackElement.h', u'Source/WebCore/html/HTMLUListElement.h', u'Source/WebCore/html/HTMLUnknownElement.h', u'Source/WebCore/html/HTMLVideoElement.h', u'Source/WebCore/html/HTMLViewSourceDocument.h', u'Source/WebCore/html/ImageDocument.cpp', u'Source/WebCore/html/ImageDocument.h', u'Source/WebCore/html/LabelableElement.h', u'Source/WebCore/html/LabelsNodeList.h', u'Source/WebCore/html/MediaController.h', u'Source/WebCore/html/MediaDocument.cpp', u'Source/WebCore/html/MediaDocument.h', u'Source/WebCore/html/MediaFragmentURIParser.h', u'Source/WebCore/html/PluginDocument.cpp', u'Source/WebCore/html/PluginDocument.h', u'Source/WebCore/html/RangeInputType.h', u'Source/WebCore/html/TextDocument.h', u'Source/WebCore/html/parser/TextDocumentParser.h', u'Source/WebCore/html/parser/TextViewSourceParser.h', u'Source/WebCore/html/shadow/DetailsMarkerControl.h', u'Source/WebCore/html/shadow/MediaControlElementTypes.h', u'Source/WebCore/html/shadow/MediaControlElements.h', u'Source/WebCore/html/shadow/MeterShadowElement.h', u'Source/WebCore/html/shadow/ProgressShadowElement.h', u'Source/WebCore/html/shadow/SliderThumbElement.h', u'Source/WebCore/html/shadow/SpinButtonElement.h', u'Source/WebCore/html/shadow/TextControlInnerElements.h', u'Source/WebCore/html/shadow/YouTubeEmbedShadowElement.h', u'Source/WebCore/html/track/TextTrack.h', u'Source/WebCore/html/track/TextTrackCue.h', u'Source/WebCore/html/track/TextTrackCueGeneric.cpp', u'Source/WebCore/html/track/TextTrackCueGeneric.h', u'Source/WebCore/html/track/TrackListBase.h', u'Source/WebCore/html/track/WebVTTElement.h', u'Source/WebCore/inspector/CommandLineAPIModule.h', u'Source/WebCore/inspector/InjectedScriptCanvasModule.h', u'Source/WebCore/inspector/InspectorConsoleAgent.cpp', u'Source/WebCore/inspector/InspectorController.h', u'Source/WebCore/inspector/InspectorDebuggerAgent.h', u'Source/WebCore/inspector/PageConsoleAgent.cpp', u'Source/WebCore/inspector/PageInjectedScriptHost.h', u'Source/WebCore/inspector/PageInjectedScriptManager.h', u'Source/WebCore/inspector/WorkerInspectorController.h', u'Source/WebCore/loader/SinkDocument.cpp', u'Source/WebCore/loader/SinkDocument.h', u'Source/WebCore/loader/appcache/DOMApplicationCache.h', u'Source/WebCore/loader/cache/CachedCSSStyleSheet.h', u'Source/WebCore/loader/cache/CachedFont.h', u'Source/WebCore/loader/cache/CachedRawResource.h', u'Source/WebCore/loader/cache/CachedSVGDocument.h', u'Source/WebCore/loader/cache/CachedScript.h', u'Source/WebCore/loader/cache/CachedShader.h', u'Source/WebCore/loader/cache/CachedTextTrack.h', u'Source/WebCore/loader/cache/CachedXSLStyleSheet.h', u'Source/WebCore/loader/icon/IconLoader.h', u'Source/WebCore/mathml/MathMLSelectElement.h', u'Source/WebCore/page/DOMTimer.h', u'Source/WebCore/page/DOMWindow.h', u'Source/WebCore/page/EventSource.h', u'Source/WebCore/page/Frame.h', u'Source/WebCore/page/FrameView.h', u'Source/WebCore/page/MainFrame.h', u'Source/WebCore/page/PageDebuggable.h', u'Source/WebCore/page/PageSerializer.cpp', u'Source/WebCore/page/Performance.h', u'Source/WebCore/page/SuspendableTimer.h', u'Source/WebCore/page/animation/KeyframeAnimation.h', u'Source/WebCore/page/scrolling/ScrollingStateFixedNode.h', u'Source/WebCore/page/scrolling/ScrollingStateScrollingNode.h', u'Source/WebCore/page/scrolling/ScrollingStateStickyNode.h', u'Source/WebCore/platform/ClockGeneric.h', u'Source/WebCore/platform/efl/ScrollbarThemeEfl.h', u'Source/WebCore/platform/graphics/BitmapImage.h', u'Source/WebCore/platform/graphics/CrossfadeGeneratedImage.h', u'Source/WebCore/platform/graphics/GradientImage.h', u'Source/WebCore/platform/graphics/SimpleFontData.h', u'Source/WebCore/platform/graphics/avfoundation/objc/AudioTrackPrivateMediaSourceAVFObjC.h', u'Source/WebCore/platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.h', u'Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h', u'Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm', u'Source/WebCore/platform/graphics/avfoundation/objc/VideoTrackPrivateAVFObjC.h', u'Source/WebCore/platform/graphics/avfoundation/objc/VideoTrackPrivateMediaSourceAVFObjC.h', u'Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.h', u'Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.h', u'Source/WebCore/platform/graphics/cg/PDFDocumentImage.h', u'Source/WebCore/platform/graphics/gstreamer/AudioTrackPrivateGStreamer.h', u'Source/WebCore/platform/graphics/gstreamer/MediaSourceGStreamer.h', u'Source/WebCore/platform/graphics/gstreamer/SourceBufferPrivateGStreamer.h', u'Source/WebCore/platform/graphics/gstreamer/VideoTrackPrivateGStreamer.h', u'Source/WebCore/platform/ios/WebSafeGCActivityCallbackIOS.h', u'Source/WebCore/platform/ios/WebSafeIncrementalSweeperIOS.h', u'Source/WebCore/platform/mac/PlatformClockCA.h', u'Source/WebCore/platform/mac/PlatformClockCM.h', u'Source/WebCore/platform/mac/ScrollAnimatorMac.h', u'Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.h', u'Source/WebCore/platform/mediastream/mac/MediaStreamCenterMac.h', u'Source/WebCore/platform/mock/MockMediaStreamCenter.h', u'Source/WebCore/platform/mock/RTCDataChannelHandlerMock.h', u'Source/WebCore/platform/mock/RTCPeerConnectionHandlerMock.h', u'Source/WebCore/platform/mock/mediasource/MockBox.h', u'Source/WebCore/platform/mock/mediasource/MockMediaSourcePrivate.h', u'Source/WebCore/platform/mock/mediasource/MockSourceBufferPrivate.cpp', u'Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.h', u'Source/WebCore/platform/network/cf/SynchronousResourceHandleCFURLConnectionDelegate.h', u'Source/WebCore/platform/text/LocaleNone.cpp', u'Source/WebCore/platform/text/PlatformLocale.cpp', u'Source/WebCore/rendering/EllipsisBox.h', u'Source/WebCore/rendering/FilterEffectRenderer.h', u'Source/WebCore/rendering/InlineElementBox.h', u'Source/WebCore/rendering/InlineFlowBox.h', u'Source/WebCore/rendering/InlineTextBox.h', u'Source/WebCore/rendering/RenderBlock.h', u'Source/WebCore/rendering/RenderBlockFlow.h', u'Source/WebCore/rendering/RenderBox.cpp', u'Source/WebCore/rendering/RenderBox.h', u'Source/WebCore/rendering/RenderButton.h', u'Source/WebCore/rendering/RenderCombineText.h', u'Source/WebCore/rendering/RenderCounter.h', u'Source/WebCore/rendering/RenderDeprecatedFlexibleBox.h', u'Source/WebCore/rendering/RenderDetailsMarker.h', u'Source/WebCore/rendering/RenderElement.h', u'Source/WebCore/rendering/RenderEmbeddedObject.h', u'Source/WebCore/rendering/RenderFieldset.h', u'Source/WebCore/rendering/RenderFileUploadControl.h', u'Source/WebCore/rendering/RenderFlexibleBox.h', u'Source/WebCore/rendering/RenderFlowThread.h', u'Source/WebCore/rendering/RenderFrame.h', u'Source/WebCore/rendering/RenderFrameSet.h', u'Source/WebCore/rendering/RenderFullScreen.cpp', u'Source/WebCore/rendering/RenderFullScreen.h', u'Source/WebCore/rendering/RenderGrid.h', u'Source/WebCore/rendering/RenderHTMLCanvas.h', u'Source/WebCore/rendering/RenderIFrame.h', u'Source/WebCore/rendering/RenderImage.h', u'Source/WebCore/rendering/RenderInline.h', u'Source/WebCore/rendering/RenderLayer.h', u'Source/WebCore/rendering/RenderLayerFilterInfo.h', u'Source/WebCore/rendering/RenderLineBreak.h', u'Source/WebCore/rendering/RenderListBox.h', u'Source/WebCore/rendering/RenderListItem.h', u'Source/WebCore/rendering/RenderListMarker.h', u'Source/WebCore/rendering/RenderMedia.h', u'Source/WebCore/rendering/RenderMediaControlElements.h', u'Source/WebCore/rendering/RenderMenuList.h', u'Source/WebCore/rendering/RenderMeter.h', u'Source/WebCore/rendering/RenderMultiColumnBlock.h', u'Source/WebCore/rendering/RenderMultiColumnFlowThread.h', u'Source/WebCore/rendering/RenderMultiColumnSet.h', u'Source/WebCore/rendering/RenderNamedFlowFragment.h', u'Source/WebCore/rendering/RenderNamedFlowThread.h', u'Source/WebCore/rendering/RenderProgress.h', u'Source/WebCore/rendering/RenderQuote.h', u'Source/WebCore/rendering/RenderRegion.h', u'Source/WebCore/rendering/RenderRegionSet.h', u'Source/WebCore/rendering/RenderReplaced.h', u'Source/WebCore/rendering/RenderReplica.h', u'Source/WebCore/rendering/RenderRuby.h', u'Source/WebCore/rendering/RenderRubyBase.h', u'Source/WebCore/rendering/RenderRubyRun.h', u'Source/WebCore/rendering/RenderRubyText.h', u'Source/WebCore/rendering/RenderScrollbar.h', u'Source/WebCore/rendering/RenderScrollbarPart.h', u'Source/WebCore/rendering/RenderSearchField.h', u'Source/WebCore/rendering/RenderSlider.h', u'Source/WebCore/rendering/RenderSnapshottedPlugIn.h', u'Source/WebCore/rendering/RenderTable.h', u'Source/WebCore/rendering/RenderTableCaption.h', u'Source/WebCore/rendering/RenderTableCell.h', u'Source/WebCore/rendering/RenderTableCol.h', u'Source/WebCore/rendering/RenderTableRow.h', u'Source/WebCore/rendering/RenderTableSection.h', u'Source/WebCore/rendering/RenderText.h', u'Source/WebCore/rendering/RenderTextControl.h', u'Source/WebCore/rendering/RenderTextControlMultiLine.h', u'Source/WebCore/rendering/RenderTextControlSingleLine.h', u'Source/WebCore/rendering/RenderTextFragment.h', u'Source/WebCore/rendering/RenderTextTrackCue.h', u'Source/WebCore/rendering/RenderVideo.h', u'Source/WebCore/rendering/RenderView.h', u'Source/WebCore/rendering/RenderWidget.h', u'Source/WebCore/rendering/RootInlineBox.h', u'Source/WebCore/rendering/TrailingFloatsRootInlineBox.h', u'Source/WebCore/rendering/mathml/RenderMathMLBlock.h', u'Source/WebCore/rendering/mathml/RenderMathMLFenced.h', u'Source/WebCore/rendering/mathml/RenderMathMLFraction.h', u'Source/WebCore/rendering/mathml/RenderMathMLMath.h', u'Source/WebCore/rendering/mathml/RenderMathMLOperator.h', u'Source/WebCore/rendering/mathml/RenderMathMLRoot.h', u'Source/WebCore/rendering/mathml/RenderMathMLRow.h', u'Source/WebCore/rendering/mathml/RenderMathMLScripts.h', u'Source/WebCore/rendering/mathml/RenderMathMLSpace.h', u'Source/WebCore/rendering/mathml/RenderMathMLSquareRoot.h', u'Source/WebCore/rendering/shapes/ShapeInsideInfo.h', u'Source/WebCore/rendering/shapes/ShapeOutsideInfo.h', u'Source/WebCore/rendering/style/ContentData.h', u'Source/WebCore/rendering/style/StyleCachedImage.h', u'Source/WebCore/rendering/style/StyleCachedImageSet.h', u'Source/WebCore/rendering/style/StyleGeneratedImage.h', u'Source/WebCore/rendering/svg/RenderSVGBlock.h', u'Source/WebCore/rendering/svg/RenderSVGContainer.h', u'Source/WebCore/rendering/svg/RenderSVGEllipse.h', u'Source/WebCore/rendering/svg/RenderSVGForeignObject.h', u'Source/WebCore/rendering/svg/RenderSVGGradientStop.h', u'Source/WebCore/rendering/svg/RenderSVGHiddenContainer.h', u'Source/WebCore/rendering/svg/RenderSVGImage.h', u'Source/WebCore/rendering/svg/RenderSVGInline.h', u'Source/WebCore/rendering/svg/RenderSVGInlineText.h', u'Source/WebCore/rendering/svg/RenderSVGModelObject.h', u'Source/WebCore/rendering/svg/RenderSVGPath.h', u'Source/WebCore/rendering/svg/RenderSVGRect.h', u'Source/WebCore/rendering/svg/RenderSVGResourceClipper.h', u'Source/WebCore/rendering/svg/RenderSVGResourceContainer.h', u'Source/WebCore/rendering/svg/RenderSVGResourceFilter.h', u'Source/WebCore/rendering/svg/RenderSVGResourceFilterPrimitive.h', u'Source/WebCore/rendering/svg/RenderSVGResourceGradient.h', u'Source/WebCore/rendering/svg/RenderSVGResourceLinearGradient.h', u'Source/WebCore/rendering/svg/RenderSVGResourceMarker.h', u'Source/WebCore/rendering/svg/RenderSVGResourceMasker.h', u'Source/WebCore/rendering/svg/RenderSVGResourcePattern.h', u'Source/WebCore/rendering/svg/RenderSVGResourceRadialGradient.h', u'Source/WebCore/rendering/svg/RenderSVGRoot.h', u'Source/WebCore/rendering/svg/RenderSVGShape.cpp', u'Source/WebCore/rendering/svg/RenderSVGShape.h', u'Source/WebCore/rendering/svg/RenderSVGTSpan.h', u'Source/WebCore/rendering/svg/RenderSVGText.h', u'Source/WebCore/rendering/svg/RenderSVGTextPath.h', u'Source/WebCore/rendering/svg/RenderSVGTransformableContainer.h', u'Source/WebCore/rendering/svg/RenderSVGViewportContainer.h', u'Source/WebCore/rendering/svg/SVGInlineFlowBox.h', u'Source/WebCore/rendering/svg/SVGInlineTextBox.h', u'Source/WebCore/rendering/svg/SVGRootInlineBox.h', u'Source/WebCore/rendering/svg/SVGTextRunRenderingContext.h', u'Source/WebCore/svg/SVGAElement.h', u'Source/WebCore/svg/SVGAltGlyphDefElement.h', u'Source/WebCore/svg/SVGAltGlyphElement.h', u'Source/WebCore/svg/SVGAltGlyphItemElement.h', u'Source/WebCore/svg/SVGAnimateColorElement.h', u'Source/WebCore/svg/SVGAnimateMotionElement.h', u'Source/WebCore/svg/SVGAnimateTransformElement.h', u'Source/WebCore/svg/SVGAnimatedAngle.h', u'Source/WebCore/svg/SVGAnimatedBoolean.h', u'Source/WebCore/svg/SVGAnimatedColor.h', u'Source/WebCore/svg/SVGAnimatedEnumeration.h', u'Source/WebCore/svg/SVGAnimatedInteger.h', u'Source/WebCore/svg/SVGAnimatedIntegerOptionalInteger.h', u'Source/WebCore/svg/SVGAnimatedLength.h', u'Source/WebCore/svg/SVGAnimatedLengthList.h', u'Source/WebCore/svg/SVGAnimatedNumber.h', u'Source/WebCore/svg/SVGAnimatedNumberList.h', u'Source/WebCore/svg/SVGAnimatedNumberOptionalNumber.h', u'Source/WebCore/svg/SVGAnimatedPath.h', u'Source/WebCore/svg/SVGAnimatedPointList.h', u'Source/WebCore/svg/SVGAnimatedPreserveAspectRatio.h', u'Source/WebCore/svg/SVGAnimatedRect.h', u'Source/WebCore/svg/SVGAnimatedString.h', u'Source/WebCore/svg/SVGAnimatedTransformList.h', u'Source/WebCore/svg/SVGCircleElement.h', u'Source/WebCore/svg/SVGClipPathElement.h', u'Source/WebCore/svg/SVGCursorElement.h', u'Source/WebCore/svg/SVGDefsElement.h', u'Source/WebCore/svg/SVGDescElement.h', u'Source/WebCore/svg/SVGDocument.h', u'Source/WebCore/svg/SVGElement.h', u'Source/WebCore/svg/SVGEllipseElement.h', u'Source/WebCore/svg/SVGFEBlendElement.h', u'Source/WebCore/svg/SVGFEColorMatrixElement.h', u'Source/WebCore/svg/SVGFEComponentTransferElement.h', u'Source/WebCore/svg/SVGFECompositeElement.h', u'Source/WebCore/svg/SVGFEConvolveMatrixElement.h', u'Source/WebCore/svg/SVGFEDiffuseLightingElement.h', u'Source/WebCore/svg/SVGFEDisplacementMapElement.h', u'Source/WebCore/svg/SVGFEDistantLightElement.h', u'Source/WebCore/svg/SVGFEDropShadowElement.h', u'Source/WebCore/svg/SVGFEFloodElement.h', u'Source/WebCore/svg/SVGFEFuncAElement.h', u'Source/WebCore/svg/SVGFEFuncBElement.h', u'Source/WebCore/svg/SVGFEFuncGElement.h', u'Source/WebCore/svg/SVGFEFuncRElement.h', u'Source/WebCore/svg/SVGFEGaussianBlurElement.h', u'Source/WebCore/svg/SVGFEImageElement.h', u'Source/WebCore/svg/SVGFEMergeElement.h', u'Source/WebCore/svg/SVGFEMergeNodeElement.h', u'Source/WebCore/svg/SVGFEMorphologyElement.h', u'Source/WebCore/svg/SVGFEOffsetElement.h', u'Source/WebCore/svg/SVGFEPointLightElement.h', u'Source/WebCore/svg/SVGFESpecularLightingElement.h', u'Source/WebCore/svg/SVGFESpotLightElement.h', u'Source/WebCore/svg/SVGFETileElement.h', u'Source/WebCore/svg/SVGFETurbulenceElement.h', u'Source/WebCore/svg/SVGFilterElement.h', u'Source/WebCore/svg/SVGFontElement.h', u'Source/WebCore/svg/SVGFontFaceElement.h', u'Source/WebCore/svg/SVGFontFaceFormatElement.h', u'Source/WebCore/svg/SVGFontFaceNameElement.h', u'Source/WebCore/svg/SVGFontFaceSrcElement.h', u'Source/WebCore/svg/SVGFontFaceUriElement.h', u'Source/WebCore/svg/SVGForeignObjectElement.h', u'Source/WebCore/svg/SVGGElement.h', u'Source/WebCore/svg/SVGGlyphElement.h', u'Source/WebCore/svg/SVGGlyphRefElement.h', u'Source/WebCore/svg/SVGHKernElement.h', u'Source/WebCore/svg/SVGImageElement.h', u'Source/WebCore/svg/SVGLineElement.h', u'Source/WebCore/svg/SVGLinearGradientElement.h', u'Source/WebCore/svg/SVGMPathElement.h', u'Source/WebCore/svg/SVGMarkerElement.h', u'Source/WebCore/svg/SVGMaskElement.h', u'Source/WebCore/svg/SVGMetadataElement.h', u'Source/WebCore/svg/SVGMissingGlyphElement.h', u'Source/WebCore/svg/SVGPathElement.h', u'Source/WebCore/svg/SVGPathStringBuilder.h', u'Source/WebCore/svg/SVGPatternElement.h', u'Source/WebCore/svg/SVGPolygonElement.h', u'Source/WebCore/svg/SVGPolylineElement.h', u'Source/WebCore/svg/SVGRadialGradientElement.h', u'Source/WebCore/svg/SVGRectElement.h', u'Source/WebCore/svg/SVGSVGElement.h', u'Source/WebCore/svg/SVGScriptElement.h', u'Source/WebCore/svg/SVGSetElement.h', u'Source/WebCore/svg/SVGStopElement.h', u'Source/WebCore/svg/SVGStyleElement.h', u'Source/WebCore/svg/SVGSwitchElement.h', u'Source/WebCore/svg/SVGSymbolElement.h', u'Source/WebCore/svg/SVGTRefElement.h', u'Source/WebCore/svg/SVGTSpanElement.h', u'Source/WebCore/svg/SVGTextContentElement.h', u'Source/WebCore/svg/SVGTextElement.h', u'Source/WebCore/svg/SVGTextPathElement.h', u'Source/WebCore/svg/SVGTitleElement.h', u'Source/WebCore/svg/SVGUnknownElement.h', u'Source/WebCore/svg/SVGUseElement.h', u'Source/WebCore/svg/SVGVKernElement.h', u'Source/WebCore/svg/SVGViewElement.h', u'Source/WebCore/svg/animation/SVGSMILElement.h', u'Source/WebCore/svg/graphics/SVGImage.h', u'Source/WebCore/svg/graphics/SVGImageForContainer.h', u'Source/WebCore/svg/graphics/filters/SVGFilter.h', u'Source/WebCore/workers/AbstractWorker.h', u'Source/WebCore/workers/SharedWorker.h', u'Source/WebCore/workers/Worker.h', u'Source/WebCore/workers/WorkerEventQueue.cpp', u'Source/WebCore/workers/WorkerEventQueue.h', u'Source/WebCore/workers/WorkerGlobalScope.h', u'Source/WebCore/xml/XMLHttpRequest.h', u'Source/WebCore/xml/XMLHttpRequestUpload.h', u'Source/WebCore/xml/XPathFunctions.cpp', u'Source/WebCore/xml/XPathPath.h', u'Source/WebCore/xml/XPathPredicate.h', u'Source/WebCore/xml/XSLStyleSheet.h', u'Source/WebKit/ios/ChangeLog', u'Source/WebKit/ios/WebCoreSupport/WebDiskImageCacheClientIOS.h', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/WebCoreSupport/WebUserMediaClient.h', u'Source/WebKit/mac/WebView/WebScriptDebugger.h', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.h', u'Source/WebKit2/NetworkProcess/RemoteNetworkingContext.h', u'Source/WebKit2/Shared/API/Cocoa/RemoteObjectRegistry.h', u'Source/WebKit2/Shared/APIArray.h', u'Source/WebKit2/Shared/APIString.h', u'Source/WebKit2/Shared/AsyncRequest.h', u'Source/WebKit2/Shared/AsyncTask.h', u'Source/WebKit2/Shared/cf/KeyedEncoder.h', u'Source/WebKit2/UIProcess/API/gtk/PageClientImpl.h', u'Source/WebKit2/UIProcess/API/mac/PageClientImpl.h', u'Source/WebKit2/UIProcess/efl/WebViewEfl.h', u'Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.h', u'Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBServerConnection.h', u'Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.h', u'Source/WebKit2/WebProcess/Storage/StorageAreaImpl.h', u'Source/WebKit2/WebProcess/WebPage/mac/GraphicsLayerCARemote.h', u'Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.h', u'Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemoteTiledBacking.h', '--commit-queue']" exit_code: 1
ERROR: Source/WebCore/workers/SharedWorker.h:41:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/rendering/RenderBlock.h:192:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/WebCore/rendering/RenderBlock.h:208:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
Total errors found: 3 in 563 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Benjamin Poulain]

Comment on attachment 221414 [details]
Patch

Awesome!

[Anders Carlsson]

Committed r162158: <http://trac.webkit.org/changeset/162158>