Bug 127125

Summary:

Web Inspector: add more context to Object.addEventListener assertions

Product:

WebKit

Reporter:

BJ Burg <bburg>

Component:

WebCore Misc.

Assignee:

BJ Burg <bburg>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, joepeck, timothy

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	none

Description BJ Burg 2014-01-16 11:29:45 PST

I seem to find myself adding this back in frequently when debugging events.. might as well submit it.

Comment 1 BJ Burg 2014-01-16 11:37:11 PST

Created attachment 221396 [details]
patch

Comment 2 Joseph Pecoraro 2014-01-16 12:52:54 PST

Comment on attachment 221396 [details]
patch

r=me

Maybe you could even do console.assert(condition, "reason", "(", arguments, ")")

Comment 3 BJ Burg 2014-01-16 12:55:16 PST

I don't think console will understand how to display arguments.

Comment 4 WebKit Commit Bot 2014-01-16 13:48:31 PST

Comment on attachment 221396 [details]
patch

Clearing flags on attachment: 221396

Committed r162149: <http://trac.webkit.org/changeset/162149>

Comment 5 WebKit Commit Bot 2014-01-16 13:48:33 PST

All reviewed patches have been landed.  Closing bug.