Bug 12711

Summary:

Prettier and more distinct cursors

Product:

WebKit

Reporter:

Lars Næsbye Christensen <lars>

Component:

CSS

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Trivial

Priority:

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
suggested cursor images update	timothy: review-
new patch without waitCursor changes	aroben: review+
patch with mime-types set correctly	aroben: review+

Lars Næsbye Christensen

Reported 2007-02-09 08:37:53 PST

* The use of the old 'wait' cursor is discouraged : http://developer.apple.com/documentation/UserExperience/Conceptual/OSXHIGuidelines/XHIGCursors/chapter_15_section_2.html We should instead use an arrowless version of our progress cursor (ie just the Aqua beachball). * The crosshair cursor is quite smallish and dull compared to the rest of the standard cursors. MacOS X already has a crosshair (allegedly available through Carbon) * The 'not allowed' and 'no-drop' are mapped to the same cursor image - but should be different, with the 'not-allowed' cursor being without the arrowhead. * The NWSE and NESW resize cursors are too wide compared to their 'siblings' - my fault from a previous patch, sorry!

Attachments
suggested cursor images update (12.35 KB, patch) 2007-02-09 08:39 PST, Lars Næsbye Christensen	timothy: review-	Details Formatted Diff Diff
new patch without waitCursor changes (8.34 KB, patch) 2007-02-12 13:48 PST, Lars Næsbye Christensen	aroben: review+	Details Formatted Diff Diff
patch with mime-types set correctly (8.25 KB, patch) 2007-02-13 09:07 PST, Lars Næsbye Christensen	aroben: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Lars Næsbye Christensen

Comment 1 2007-02-09 08:39:24 PST

Created attachment 13085 [details] suggested cursor images update

Maciej Stachowiak

Comment 2 2007-02-10 16:22:50 PST

Looks neat, but not really appropriate during our stabilization cycle. Will let UI type people decide.

Timothy Hatcher

Comment 3 2007-02-11 12:48:37 PST

Comment on attachment 13085 [details] suggested cursor images update This is almost good to land. The resize cursors are fine, along with the not allowed cursor and crosshsir. The wait cursor should change, but it needs to animate. We should use the blue animated version with the arrow.

Lars Næsbye Christensen

Comment 4 2007-02-12 13:48:17 PST

Created attachment 13141 [details] new patch without waitCursor changes OK, here's a version without the changes to the waitCursor. We don't have a 'good' cursor animation routine at the present (I'll look into it). When it comes, the wait and progress cursors should definitely be animated, I agree.

Adam Roben (:aroben)

Comment 5 2007-02-12 22:40:51 PST

Comment on attachment 13141 [details] new patch without waitCursor changes r=me, although it would be great if you could upload a new version with svn:mime-type set to image/png on the new images before this gets landed.

Lars Næsbye Christensen

Comment 6 2007-02-13 09:07:09 PST

Created attachment 13149 [details] patch with mime-types set correctly :-) certainly!

Adam Roben (:aroben)

Comment 7 2007-02-13 14:30:04 PST

Comment on attachment 13149 [details] patch with mime-types set correctly r=me!

Adele Peterson

Comment 8 2007-02-17 11:09:36 PST

Committed revision 19682.

Note You need to log in before you can comment on or make changes to this bug.