Bug 127061

Summary: Make zlib configure detection work on FreeBSD
Product: WebKit Reporter: Koop Mast <kwm>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, commit-queue, desrt
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Other   
Bug Depends on:    
Bug Blocks: 128598    
Attachments:
Description Flags
Add fallback to manual check for zlib, if no zlib pkg-config file is available.
none
Updated patch to fix style problem in Changelog. gustavo: review+

Koop Mast
Reported 2014-01-15 12:52:56 PST
Created attachment 221296 [details] Add fallback to manual check for zlib, if no zlib pkg-config file is available. The zlib supplied with FreeBSD doesn't have a pkg-config file.
Attachments
Add fallback to manual check for zlib, if no zlib pkg-config file is available. (1015 bytes, patch)
2014-01-15 12:52 PST, Koop Mast 		no flags
DetailsFormatted DiffDiff
Updated patch to fix style problem in Changelog. (1.04 KB, patch)
2014-01-18 06:47 PST, Koop Mast 		gustavo: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
WebKit Commit Bot
Comment 1 2014-01-15 12:55:22 PST
Attachment 221296 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'Source/autotools/FindDependencies.m4', '--commit-queue']" exit_code: 1 ERROR: ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Koop Mast
Comment 2 2014-01-18 06:47:55 PST
Created attachment 221545 [details] Updated patch to fix style problem in Changelog.
Alberto Garcia
Comment 3 2014-02-27 05:32:09 PST
(In reply to comment #2) > Created an attachment (id=221545) [details] > Updated patch to fix style problem in Changelog. lgtm
Alberto Garcia
Comment 4 2014-02-27 05:43:35 PST
Committed r164796: <http://trac.webkit.org/changeset/164796>
Note You need to log in before you can comment on or make changes to this bug.