Bug 127058

Summary:

REGRESSION: Crash in -[WebPreferences _valueForKey:] when AdBlock extension is installed

Product:

WebKit

Reporter:

Dimitris Apostolou <dimitris.apostolou>

Component:

Plug-ins

Assignee:

Nobody <webkit-unassigned>

Status:

CLOSED FIXED

Severity:

Blocker

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac (Intel)

OS:

OS X 10.9

Attachments:

Description	Flags
Crash log	none

Description Dimitris Apostolou 2014-01-15 11:32:56 PST

Created attachment 221287 [details]
Crash log

r162066

Reproducibility: always

Prerequisites:
Have AdBlock 2.6.18 extension installed.

Steps:
Launch WebKit r162066

What happened:

Enabled Extensions:
com.betafish.adblockforsafari-UAMUU4S2D9 (102.6.18 - 2.6.18) AdBlock
 

Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   com.apple.WebKit              	0x0000000109243b8b -[WebPreferences _valueForKey:] + 27
1   com.apple.WebKit              	0x0000000109243d83 -[WebPreferences _integerValueForKey:] + 19
2   com.apple.WebKit              	0x0000000109243fe1 -[WebPreferences _boolValueForKey:] + 17
3   com.apple.WebKit              	0x0000000109244a48 -[WebPreferences privateBrowsingEnabled] + 24
4   com.apple.WebKit              	0x0000000109243ade -[WebPreferences dealloc] + 30
5   com.apple.WebKit              	0x0000000109241e2f -[WebPreferences initWithIdentifier:] + 79
6   com.apple.Safari.framework    	0x0000000106e9065e Safari::ExtensionViewController::makeWebPreferences() + 68
7   com.apple.Safari.framework    	0x0000000106e9058b Safari::ExtensionViewController::createAndLoadView() + 335
8   com.apple.Safari.framework    	0x0000000106e77a4f Safari::ExtensionGlobalPageViewController::ExtensionGlobalPageViewController(Safari::Extension*, Safari::CF::URL const&) + 51
9   com.apple.Safari.framework    	0x0000000106e66883 Safari::ExtensionGlobalPageViewController::create(Safari::Extension*, Safari::CF::URL const&) + 47
10  com.apple.Safari.framework    	0x0000000106e5f5fb Safari::Extension::retrieveGlobalWebView() + 47
11  com.apple.Safari.framework    	0x0000000106e5ed09 Safari::Extension::enable() + 87
12  com.apple.Safari.framework    	0x0000000106e7e551 Safari::ExtensionsController::loadInstalledExtensions() + 417
13  com.apple.Safari.framework    	0x0000000106e7d489 Safari::ExtensionsController::reloadAllExtensions() + 77
14  com.apple.Safari.framework    	0x0000000106d26315 -[AppController awakeFromNib] + 1293
15  com.apple.CoreFoundation      	0x000000010a190709 -[NSSet makeObjectsPerformSelector:] + 201
16  com.apple.AppKit              	0x000000010b2dff8d -[NSIBObjectData nibInstantiateWithOwner:topLevelObjects:] + 1157
17  com.apple.AppKit              	0x000000010b2d4a5e loadNib + 327
18  com.apple.AppKit              	0x000000010b2d3ffc +[NSBundle(NSNibLoading) _loadNibFile:nameTable:withZone:ownerBundle:] + 288
19  com.apple.AppKit              	0x000000010b2d3dec -[NSBundle(NSNibLoading) loadNibNamed:owner:topLevelObjects:] + 197
20  com.apple.AppKit              	0x000000010b2d3bdb +[NSBundle(NSNibLoading) loadNibNamed:owner:] + 357
21  com.apple.AppKit              	0x000000010b2cfa87 NSApplicationMain + 448
22  com.apple.Safari.framework    	0x0000000106f4af3d SafariMain + 267
23  libdyld.dylib                 	0x000000010d95b5fd start + 1

Expected result:
Webkit does not crash.

Notes:
This is regression from r161944

Comment 1 Dimitris Apostolou 2014-01-15 19:11:18 PST

Fixed with r162097