| Summary: | [CSS Grid Layout] minmax() should be a CSSFunction instead of a CSSValueList | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sergio Villar Senin <svillar> | ||||||||
| Component: | CSS | Assignee: | Sergio Villar Senin <svillar> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | allan.jensen, buildbot, commit-queue, esprehn+autocc, glenn, gyuyoung.kim, kling, koivisto, krit, macpherson, menard, rniwa, simon.fraser, svillar | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | 127055 | ||||||||||
| Bug Blocks: | 127033 | ||||||||||
| Attachments: |
|
||||||||||
Setting a dependency as I prefer the dependency to land first as it will drastically simplify the patch for this test (significantly reducing the amount of code for the tests) Created attachment 221663 [details]
Patch
Comment on attachment 221663 [details]
Patch
Forgot to upload some missing pieces, new patch to come...
Comment on attachment 221663 [details] Patch Attachment 221663 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5857543372931072 New failing tests: fast/css-grid-layout/grid-columns-rows-get-set-multiple.html fast/css-grid-layout/grid-columns-rows-get-set.html fast/css-grid-layout/named-grid-line-get-set.html Created attachment 221668 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Created attachment 221670 [details]
Patch
Comment on attachment 221670 [details] Patch Clearing flags on attachment: 221670 Committed r163013: <http://trac.webkit.org/changeset/163013> All reviewed patches have been landed. Closing bug. |
We're internally treating the minmax() function as a list of CSSValue instead of a CSSFunction. The problem with that is that a declaration like -webkit-grid-definition-columns: minmax(10px, 50px) will be transformed, when asking for "element.style.webkitGridDefinitionColumns" in "10px 50px" i.e. a string with a list of values instead of "minmax(10px, 50px)" which is the correct value in this case.