Bug 127031

Summary: [EFL][WK1] Implement ProgressTrackerClientEfl to fix the crash
Product: WebKit Reporter: Ryuan Choi <ryuan.choi>
Component: WebKit EFLAssignee: Ryuan Choi <ryuan.choi>
Status: RESOLVED FIXED    
Severity: Normal CC: bunhere, cdumez, commit-queue, gyuyoung.kim, lucas.de.marchi, rakuco
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Ryuan Choi 2014-01-14 21:56:58 PST 
Since r162034, ProgressTrackerClient should be an instance out of LoaderClient
Comment 1 Ryuan Choi 2014-01-14 22:02:34 PST 
Created attachment 221230 [details]
Patch
Comment 2 Gyuyoung Kim 2014-01-15 01:18:41 PST 
Comment on attachment 221230 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221230&action=review

> Source/WebKit/efl/WebCoreSupport/ProgressTrackerClientEfl.h:44
> +    virtual void progressTrackerDestroyed() OVERRIDE;

How about using "FINAL" as well ?
Comment 3 Gyuyoung Kim 2014-01-15 01:20:17 PST 
Comment on attachment 221230 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221230&action=review

> Source/WebKit/efl/WebCoreSupport/ProgressTrackerClientEfl.h:41
> +    explicit ProgressTrackerClientEfl(Evas_Object *);

(Evas_Object *) -> (Evas_Object*) ?
Comment 4 Ryuan Choi 2014-01-15 01:55:18 PST 
Created attachment 221244 [details]
Patch
Comment 5 Ryuan Choi 2014-01-15 01:57:36 PST 
Comment on attachment 221244 [details]
Patch

Clearing flags on attachment: 221244

Committed r162061: <http://trac.webkit.org/changeset/162061>
Comment 6 Ryuan Choi 2014-01-15 01:57:43 PST 
All reviewed patches have been landed.  Closing bug.