Bug 127025

Summary: Create separate progress tracker clients
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eflews.bot, gyuyoung.kim, japhet
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch sam: review+, eflews.bot: commit-queue-

Description Anders Carlsson 2014-01-14 17:51:53 PST
Create separate progress tracker clients
Comment 1 Anders Carlsson 2014-01-14 17:54:38 PST
Created attachment 221220 [details]
Patch
Comment 2 EFL EWS Bot 2014-01-14 18:01:16 PST
Comment on attachment 221220 [details]
Patch

Attachment 221220 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/6690946611675136
Comment 3 Sam Weinig 2014-01-14 18:18:12 PST
Comment on attachment 221220 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221220&action=review

> Source/WebKit/mac/WebCoreSupport/WebProgressTrackerClient.mm:53
> +#if !PLATFORM(IOS)
> +void WebProgressTrackerClient::willChangeEstimatedProgress()
> +{
> +    [m_webView _willChangeValueForKey:_WebEstimatedProgressKey];
> +}
> +
> +void WebProgressTrackerClient::didChangeEstimatedProgress()
> +{
> +    [m_webView _didChangeValueForKey:_WebEstimatedProgressKey];
> +}
> +#endif

I'd prefer if we still implemented these functions but just didn't call the _will/_did on iOS.
Comment 4 Anders Carlsson 2014-01-14 18:39:21 PST
Committed r162034: <http://trac.webkit.org/changeset/162034>