Summary: | Create separate progress tracker clients | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Anders Carlsson <andersca> | ||||
Component: | New Bugs | Assignee: | Anders Carlsson <andersca> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, eflews.bot, gyuyoung.kim, japhet | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Anders Carlsson
2014-01-14 17:51:53 PST
Created attachment 221220 [details]
Patch
Comment on attachment 221220 [details] Patch Attachment 221220 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/6690946611675136 Comment on attachment 221220 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=221220&action=review > Source/WebKit/mac/WebCoreSupport/WebProgressTrackerClient.mm:53 > +#if !PLATFORM(IOS) > +void WebProgressTrackerClient::willChangeEstimatedProgress() > +{ > + [m_webView _willChangeValueForKey:_WebEstimatedProgressKey]; > +} > + > +void WebProgressTrackerClient::didChangeEstimatedProgress() > +{ > + [m_webView _didChangeValueForKey:_WebEstimatedProgressKey]; > +} > +#endif I'd prefer if we still implemented these functions but just didn't call the _will/_did on iOS. Committed r162034: <http://trac.webkit.org/changeset/162034> |