Bug 127022

Summary: Web Inspector: Implement the discrete Network timeline view
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: Web InspectorAssignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Normal CC: graouts, joepeck, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
joepeck: review+, timothy: commit-queue-
Screenshot none

Timothy Hatcher
Reported 2014-01-14 17:34:01 PST
Time to add back the network timeline data grid view.
Attachments
Patch (42.23 KB, patch)
2014-01-14 17:43 PST, Timothy Hatcher 		joepeck: review+
timothy: commit-queue-
DetailsFormatted DiffDiff
Screenshot (545.37 KB, image/png)
2014-01-14 17:46 PST, Timothy Hatcher 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Timothy Hatcher
Comment 1 2014-01-14 17:43:07 PST
Created attachment 221216 [details] Patch
Radar WebKit Bug Importer
Comment 2 2014-01-14 17:43:32 PST
<rdar://problem/15820928>
Radar WebKit Bug Importer
Comment 3 2014-01-14 17:43:49 PST
<rdar://problem/15820927>
Timothy Hatcher
Comment 4 2014-01-14 17:46:10 PST
Created attachment 221217 [details] Screenshot
Joseph Pecoraro
Comment 5 2014-01-17 15:07:07 PST
Comment on attachment 221216 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=221216&action=review r=me > Source/WebInspectorUI/UserInterface/TimelineDataGrid.js:294 > + if (isNaN(value1)) > + return sortDirection * -1; > + if (isNaN(value2)) > + return sortDirection * 1; How about just return -sortDirection and return sortDirection?
Timothy Hatcher
Comment 6 2014-01-17 19:45:01 PST
Comment on attachment 221216 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=221216&action=review >> Source/WebInspectorUI/UserInterface/TimelineDataGrid.js:294 >> + return sortDirection * 1; > > How about just return -sortDirection and return sortDirection? Good idea.
Timothy Hatcher
Comment 7 2014-01-20 19:04:23 PST
https://trac.webkit.org/changeset/162415
Note You need to log in before you can comment on or make changes to this bug.