Bug 127022

Summary:

Web Inspector: Implement the discrete Network timeline view

Product:

WebKit

Reporter:

Timothy Hatcher <timothy>

Component:

Web Inspector

Assignee:

Timothy Hatcher <timothy>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

graouts, joepeck, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	joepeck: review+, timothy: commit-queue-
Screenshot	none

Description Timothy Hatcher 2014-01-14 17:34:01 PST

Time to add back the network timeline data grid view.

Comment 1 Timothy Hatcher 2014-01-14 17:43:07 PST

Created attachment 221216 [details]
Patch

Comment 2 Radar WebKit Bug Importer 2014-01-14 17:43:32 PST

<rdar://problem/15820928>

Comment 3 Radar WebKit Bug Importer 2014-01-14 17:43:49 PST

<rdar://problem/15820927>

Comment 4 Timothy Hatcher 2014-01-14 17:46:10 PST

Created attachment 221217 [details]
Screenshot

Comment 5 Joseph Pecoraro 2014-01-17 15:07:07 PST

Comment on attachment 221216 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221216&action=review

r=me

> Source/WebInspectorUI/UserInterface/TimelineDataGrid.js:294
> +            if (isNaN(value1))
> +                return sortDirection * -1;
> +            if (isNaN(value2))
> +                return sortDirection * 1;

How about just return -sortDirection and return sortDirection?

Comment 6 Timothy Hatcher 2014-01-17 19:45:01 PST

Comment on attachment 221216 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221216&action=review

>> Source/WebInspectorUI/UserInterface/TimelineDataGrid.js:294
>> +                return sortDirection * 1;
> 
> How about just return -sortDirection and return sortDirection?

Good idea.

Comment 7 Timothy Hatcher 2014-01-20 19:04:23 PST

https://trac.webkit.org/changeset/162415