Bug 127019

Summary: Crash when multiple WebView instances have different PrivateBrowsing settings
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: WebKit APIAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, commit-queue, mhock, ossy, sam
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 127053    
Bug Blocks:    
Attachments:
Description Flags
proposed fix
none
updated patch none

Alexey Proskuryakov
Reported 2014-01-14 16:35:10 PST
In WebKit1, we don't have the new WebKit2 logic that keeps track of preferences, and only deletes private browsing sessions when no pages use private browsing any more. This causes crashes for apps that have views in different modes. <rdar://problem/15484194>
Attachments
proposed fix (5.55 KB, patch)
2014-01-14 16:39 PST, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
updated patch (6.66 KB, patch)
2014-01-15 12:50 PST, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2014-01-14 16:39:01 PST
Created attachment 221214 [details] proposed fix
WebKit Commit Bot
Comment 2 2014-01-14 23:14:30 PST
Comment on attachment 221214 [details] proposed fix Clearing flags on attachment: 221214 Committed r162054: <http://trac.webkit.org/changeset/162054>
WebKit Commit Bot
Comment 3 2014-01-14 23:14:32 PST
All reviewed patches have been landed. Closing bug.
Csaba Osztrogonác
Comment 4 2014-01-15 08:19:17 PST
(In reply to comment #3) > All reviewed patches have been landed. Closing bug. It caused crashes on Apple Mac debug bots.
WebKit Commit Bot
Comment 5 2014-01-15 09:38:17 PST
Re-opened since this is blocked by bug 127053
Alexey Proskuryakov
Comment 6 2014-01-15 09:44:16 PST
Rolled out in <https://trac.webkit.org/r162075>.
Alexey Proskuryakov
Comment 7 2014-01-15 12:50:55 PST
Created attachment 221295 [details] updated patch I didn't realize that preferences weren't cached in _private->values unless they were changed in the process. So, other processes could change the private browsing preference behind the back of our session tracker, and parallel DumpRenderTrees did. It's a separate bug that DRT writes out persistent preferences.
WebKit Commit Bot
Comment 8 2014-01-15 13:26:15 PST
Comment on attachment 221295 [details] updated patch Clearing flags on attachment: 221295 Committed r162087: <http://trac.webkit.org/changeset/162087>
WebKit Commit Bot
Comment 9 2014-01-15 13:26:17 PST
All reviewed patches have been landed. Closing bug.
Alexey Proskuryakov
Comment 10 2014-01-15 14:31:29 PST
Added a null check to fix Safari crashes in <http://trac.webkit.org/r162091>.
Note You need to log in before you can comment on or make changes to this bug.