Summary: | build.webkit.org/dashboard should display information about patches in EWS | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||||
Component: | Tools / Tests | Assignee: | Alexey Proskuryakov <ap> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | rniwa, thorton, timothy | ||||||
Priority: | P3 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 127265 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Alexey Proskuryakov
2014-01-14 13:45:36 PST
Created attachment 221624 [details]
proposed patch
Created attachment 221626 [details]
screenshot
It is quite tricky to present EWS status in a useful way, because EWS design is such that it's impossible to know what each bot is doing, or what's happening with a patch right now. We only know about events after the fact, when results are logged - with the only exception of a bot taking ownership of a patch, which it does right before building for the first time.
I think that the popover will be useful anyway - for example, it is obvious in the screenshot that something is seriously wrong with a patch that took 88 attempts (I suspect that it's a bug somewhere in our toolchain, but haven't looked into it yet).
Comment on attachment 221624 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=221624&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Bugzilla.js:2 > + * Copyright (C) 2013 Apple Inc. All rights reserved. Nit: should read 2014 or 2013, 2014. > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:123 > + // The server returns all bots that have ever checked in with it. We only need currently active bots. > + var oneDayInMilliseconds = 24 * 60 * 60 * 1000; > + if (latestMessageTime < Date.now() - oneDayInMilliseconds) I would prefer declaring a local variable named like botIsCurrentlyActive instead of having a comment like this. > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js:128 > + var hours = Math.floor(timeDifference / (60 * 60)); > + var minutes = Math.floor((timeDifference - hours * 60 * 60) / 60); Can we define a constant like secondsPerHour? > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js:155 > + this.addLinkToRow(rowElement, "patch-details-link", patch.attachmentID, patch.statusPageURL); Looks like the code block below could be extracted as a helper function. Committed <http://trac.webkit.org/r162373>. |