Bug 126995 – Web Inspector: For Remote Inspection link WebProcess's to their parent UIProcess

• Component: Web Inspector
• Status: RESOLVED FIXED

[Joseph Pecoraro]

For remote inspection make WebProcesses a proxy application for the parent UIProcess.

This way, if you have multiple WebProcesses hosting multiple WebPage's then all the WebPages can be listed under the UIProcess.

[Radar WebKit Bug Importer]

<rdar://problem/15815775>

[Joseph Pecoraro]

Created attachment 221183 [details]
[PATCH] Proposed Fix

[Timothy Hatcher]

Comment on attachment 221183 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=221183&action=review

> Source/JavaScriptCore/inspector/remote/RemoteInspector.mm:301
> +        NSString *parentApplicationIdentifier = [NSString stringWithFormat:@"PID:%lu", (unsigned long)debuggableInfo.parentProcessIdentifier];

Is "PID:" needed? DO you need to strip that out later for the numeric value or do you just compare strings?

[Joseph Pecoraro]

(In reply to comment #3)
> (From update of attachment 221183 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=221183&action=review
> 
> > Source/JavaScriptCore/inspector/remote/RemoteInspector.mm:301
> > +        NSString *parentApplicationIdentifier = [NSString stringWithFormat:@"PID:%lu", (unsigned long)debuggableInfo.parentProcessIdentifier];
> 
> Is "PID:" needed? DO you need to strip that out later for the numeric value or do you just compare strings?

Nope, PID is not needed. I just wanted this to be obvious that it was a String, and if we change it to be some other number in the future then we can give another prefix for what exactly that means. E.g. "BundleID:#", "PID:#", "XPC:#", etc. Just trying to be forward thinking.

[WebKit Commit Bot]

Comment on attachment 221183 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 221183

Committed r161994: <http://trac.webkit.org/changeset/161994>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.