Bug 126982

Summary: Pack ResourceRequest harder.
Product: WebKit Reporter: Andreas Kling <kling>
Component: Page LoadingAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: eflews.bot, gyuyoung.kim, kling
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
eflews.bot: commit-queue-
Patch andersca: review+, eflews.bot: commit-queue-

Description Andreas Kling 2014-01-14 06:32:21 PST 
Pack ResourceRequest harder.
Comment 1 Andreas Kling 2014-01-14 06:32:51 PST 
Created attachment 221155 [details]
Patch
Comment 2 Andreas Kling 2014-01-14 06:33:15 PST 
Created attachment 221156 [details]
Patch
Comment 3 EFL EWS Bot 2014-01-14 06:40:25 PST 
Comment on attachment 221156 [details]
Patch

Attachment 221156 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/5682728406089728
Comment 4 EFL EWS Bot 2014-01-14 06:40:56 PST 
Comment on attachment 221156 [details]
Patch

Attachment 221156 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/5781445813469184
Comment 5 Antti Koivisto 2014-01-14 07:05:57 PST 
Comment on attachment 221156 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221156&action=review

> Source/WebCore/platform/network/ResourceRequestBase.h:202
> +        ResourceRequestCachePolicy m_cachePolicy : 3;
>          bool m_allowCookies : 1;
>          mutable bool m_resourceRequestUpdated : 1;

You probably need to change all these to unsigned
Comment 6 Andreas Kling 2014-01-14 08:10:57 PST 
Created attachment 221164 [details]
Patch
Comment 7 EFL EWS Bot 2014-01-14 09:06:00 PST 
Comment on attachment 221164 [details]
Patch

Attachment 221164 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/5709719993843712
Comment 8 Andreas Kling 2014-01-17 06:27:47 PST 
Committed r162200: <http://trac.webkit.org/changeset/162200>