Bug 126954

Summary: [iOS] Enable QuickLook
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: PlatformAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, benjamin, cmarcelo, commit-queue, dbates, ddkilzer
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ddkilzer: review+

Simon Fraser (smfr)
Reported 2014-01-13 18:33:47 PST
WTF_USE_QUICK_LOOK is missing from Platform.h
Attachments
Patch (2.69 KB, patch)
2014-01-14 14:53 PST, Daniel Bates 		ddkilzer: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2014-01-14 14:53:38 PST
Created attachment 221208 [details] Patch
David Kilzer (:ddkilzer)
Comment 2 2014-01-14 14:54:31 PST
Comment on attachment 221208 [details] Patch r=me
Daniel Bates
Comment 3 2014-01-14 14:57:28 PST
Committed r162016: <http://trac.webkit.org/changeset/162016>
Darin Adler
Comment 4 2014-01-15 09:42:53 PST
Comment on attachment 221208 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=221208&action=review > Source/WebKit/mac/WebView/WebView.mm:3635 > +#if TARGET_OS_IPHONE && USE(QUICK_LOOK) Doesn’t seem like we need the USE(QUICK_LOOK) conditional here. Unless we plan to support building for IOS with it turned off.
Note You need to log in before you can comment on or make changes to this bug.