| Summary: | [GTK] Multiple definitions of PluginPackage symbols when only enabling Wayland target | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Zan Dobersek <zan> | ||||||
| Component: | New Bugs | Assignee: | Zan Dobersek <zan> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | berto, cgarcia, gyuyoung.kim, mcatanzaro, tgergely.u-szeged | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 81456 | ||||||||
| Attachments: |
|
||||||||
|
Description
Zan Dobersek
2014-01-13 12:23:37 PST
Created attachment 221073 [details]
Patch
*** Bug 126426 has been marked as a duplicate of this bug. *** (In reply to comment #1) > Created an attachment (id=221073) [details] This is a revert of r159999, so this would probably reopen bug 123997 The GTK port doesn't support disabling ENABLE_NETSCAPE_PLUGIN_API because AFAIR the WK2 plugin process doesn't build, and the support for building without the plugin process was removed (at least for the GTK port). That's why the GTK port always includes PluginPackage.cpp into the build, and then either uses PluginPackageGtk.cpp when the X11 target is enabled, PluginPackageWin.cpp when the Win32 target is enabled, and PluginPackageNone.cpp when only the Wayland target is enabled. The proposed patch works for us, but would probably indeed reopen bug #123997. I won't force any port into specific configurations, so I'll add the ENABLE(NETSCAPE_PLUGIN_API) guards around the added code. This should work out OK for everyone. Created attachment 221337 [details]
Patch
This patch adds a FIXME relevant to the EFL port. Did this patch land? or is this still a problem with current trunk? I know some people are building wayland only and nobody else complained about this. Feel free to reopen if this is still a problem with current trunk. |