Bug 126927

Summary: [GTK] Multiple definitions of PluginPackage symbols when only enabling Wayland target
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, cgarcia, gyuyoung.kim, mcatanzaro, tgergely.u-szeged
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 81456    
Attachments:
Description Flags
Patch
none
Patch mcatanzaro: review+

Zan Dobersek
Reported 2014-01-13 12:23:37 PST
[GTK] Multiple definitions of PluginPackage symbols when only enabling Wayland target
Attachments
Patch (1.56 KB, patch)
2014-01-13 12:24 PST, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (2.26 KB, patch)
2014-01-15 23:42 PST, Zan Dobersek 		mcatanzaro: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2014-01-13 12:24:32 PST
Created attachment 221073 [details] Patch
Alberto Garcia
Comment 2 2014-01-15 04:26:43 PST
*** Bug 126426 has been marked as a duplicate of this bug. ***
Alberto Garcia
Comment 3 2014-01-15 04:29:56 PST
(In reply to comment #1) > Created an attachment (id=221073) [details] This is a revert of r159999, so this would probably reopen bug 123997
Zan Dobersek
Comment 4 2014-01-15 07:33:16 PST
The GTK port doesn't support disabling ENABLE_NETSCAPE_PLUGIN_API because AFAIR the WK2 plugin process doesn't build, and the support for building without the plugin process was removed (at least for the GTK port). That's why the GTK port always includes PluginPackage.cpp into the build, and then either uses PluginPackageGtk.cpp when the X11 target is enabled, PluginPackageWin.cpp when the Win32 target is enabled, and PluginPackageNone.cpp when only the Wayland target is enabled. The proposed patch works for us, but would probably indeed reopen bug #123997. I won't force any port into specific configurations, so I'll add the ENABLE(NETSCAPE_PLUGIN_API) guards around the added code. This should work out OK for everyone.
Zan Dobersek
Comment 5 2014-01-15 23:42:47 PST
Created attachment 221337 [details] Patch
Michael Catanzaro
Comment 6 2016-01-02 09:14:41 PST
This patch adds a FIXME relevant to the EFL port.
Carlos Garcia Campos
Comment 7 2016-09-02 22:53:36 PDT
Did this patch land? or is this still a problem with current trunk?
Carlos Garcia Campos
Comment 8 2016-09-06 05:03:02 PDT
I know some people are building wayland only and nobody else complained about this. Feel free to reopen if this is still a problem with current trunk.
Note You need to log in before you can comment on or make changes to this bug.