Summary: | AX: Do not return an accessible name for an object just because it has tabindex=0 | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | chris fleizach <cfleizach> | ||||
Component: | Accessibility | Assignee: | chris fleizach <cfleizach> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aboxhall, apinheiro, commit-queue, dmazzoni, jcraig, jdiggs, mario, samuel_white, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
chris fleizach
2014-01-13 10:03:32 PST
Created attachment 221059 [details]
patch
Comment on attachment 221059 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=221059&action=review The patch looks good to me, although I don't understand why you are getting that undefined expectation for one test. Also, I think we might potentially have to adapt the ATK port after this change, but I'm happy to give it a try now and adapt later so VO is not blocked on theories :) Setting the r+ anyway, but please take a look to the issue with the FAIL expectation before landing > LayoutTests/accessibility/focusable-div-expected.txt:17 > -PASS lastChar(axDiv.title) is "B" > +FAIL lastChar(axDiv.title) should be undefined (of type undefined). Was (of type string). This FAIL expectation looks wrong. Not sure why this is happening, though (why is "" undefined?) > LayoutTests/accessibility/focusable-div-expected.txt:19 > +FAIL lastChar(axDiv2.title) should be undefined (of type undefined). Was (of type string). Same here |