Summary: | Generated content and display: table-cell duplicates content on font size change | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Elliott Sprehn <esprehn> | ||||||||||
Component: | CSS | Assignee: | Dave Hyatt <hyatt> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | ddkilzer, mitz | ||||||||||
Priority: | P2 | Keywords: | HasReduction | ||||||||||
Version: | 420+ | ||||||||||||
Hardware: | Mac | ||||||||||||
OS: | OS X 10.4 | ||||||||||||
URL: | http://enfinitystudios.thaposse.net/personal/bugs/table-cell-error.html | ||||||||||||
Attachments: |
|
Description
Elliott Sprehn
2007-02-08 00:24:30 PST
Created attachment 13061 [details]
Test Case
Created attachment 14282 [details]
Patch to fix the problem.
This patch fixes the problem by making sure we drill into anonymous containers to find generated content that may have been wrapped.
Comment on attachment 14282 [details]
Patch to fix the problem.
There's a minor problem. Need to fix.
Created attachment 14283 [details]
Better version of patch.
Fixed a mistake made later in the function where the innermost container was incorrectly used when doing the insertion of the content. Go layout tests.
Created attachment 14284 [details]
Fix issues with table display types
Even though layout tests passed (and the reduction passed), my own further testing before landing caught some additional issues with table display types and generated content. We weren't making the right kind of anonymous container for generated content even though we kept the table display type.
Comment on attachment 14284 [details]
Fix issues with table display types
+ bool oldContentPresent = child;
For MSVC that needs to be !!child instead of just child used as a boolean.
r=me
Fixed. |