Bug 126864

Summary: Remove AtomicallyInitializedStatic
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, commit-queue, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 126877    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch kling: review+

Description Anders Carlsson 2014-01-12 18:25:43 PST 
Remove AtomicallyInitializedStatic
Comment 1 Anders Carlsson 2014-01-12 18:27:27 PST 
Created attachment 220997 [details]
Patch
Comment 2 Anders Carlsson 2014-01-12 18:32:42 PST 
Committed r161852: <http://trac.webkit.org/changeset/161852>
Comment 3 WebKit Commit Bot 2014-01-13 02:05:06 PST 
Re-opened since this is blocked by bug 126877
Comment 4 Anders Carlsson 2014-01-13 08:32:13 PST 
Created attachment 221045 [details]
Patch
Comment 5 Andreas Kling 2014-01-13 08:34:19 PST 
Comment on attachment 221045 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221045&action=review

> Source/WTF/ChangeLog:12
> +        On Mac, add them to a separate file which will hold functions and symbols that we would like
> +        to remove but that are used by Safari. Reimplement them in terms of std::call_once and std::mutex.

Good idea.
Comment 6 Anders Carlsson 2014-01-13 08:34:37 PST 
Committed r161879: <http://trac.webkit.org/changeset/161879>
Comment 7 Csaba Osztrogonác 2014-01-13 08:56:15 PST 
(In reply to comment #6)
> Committed r161879: <http://trac.webkit.org/changeset/161879>

It broke the Apple Windows build:
 1>..\wtf\ThreadingWin.cpp(170): error C2065: 'atomicallyInitializedStaticMutex' : undeclared identifier