Bug 126864

Summary: Remove AtomicallyInitializedStatic
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, commit-queue, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 126877    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch kling: review+

Anders Carlsson
Reported 2014-01-12 18:25:43 PST
Remove AtomicallyInitializedStatic
Attachments
Patch (4.69 KB, patch)
2014-01-12 18:27 PST, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (10.86 KB, patch)
2014-01-13 08:32 PST, Anders Carlsson 		kling: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2014-01-12 18:27:27 PST
Created attachment 220997 [details] Patch
Anders Carlsson
Comment 2 2014-01-12 18:32:42 PST
Committed r161852: <http://trac.webkit.org/changeset/161852>
WebKit Commit Bot
Comment 3 2014-01-13 02:05:06 PST
Re-opened since this is blocked by bug 126877
Anders Carlsson
Comment 4 2014-01-13 08:32:13 PST
Created attachment 221045 [details] Patch
Andreas Kling
Comment 5 2014-01-13 08:34:19 PST
Comment on attachment 221045 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=221045&action=review > Source/WTF/ChangeLog:12 > + On Mac, add them to a separate file which will hold functions and symbols that we would like > + to remove but that are used by Safari. Reimplement them in terms of std::call_once and std::mutex. Good idea.
Anders Carlsson
Comment 6 2014-01-13 08:34:37 PST
Committed r161879: <http://trac.webkit.org/changeset/161879>
Csaba Osztrogonác
Comment 7 2014-01-13 08:56:15 PST
(In reply to comment #6) > Committed r161879: <http://trac.webkit.org/changeset/161879> It broke the Apple Windows build: 1>..\wtf\ThreadingWin.cpp(170): error C2065: 'atomicallyInitializedStaticMutex' : undeclared identifier
Note You need to log in before you can comment on or make changes to this bug.