Bug 126858

Summary: Add deprecatedCharacters as a synonym for characters and convert most call sites
Product: WebKit Reporter: Darin Adler <darin>
Component: Web Template FrameworkAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch andersca: review+

Darin Adler
Reported 2014-01-12 15:54:06 PST
Add deprecatedCharacters as a synonym for characters and convert most call sites
Attachments
Patch (119.99 KB, patch)
2014-01-12 15:55 PST, Darin Adler 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2014-01-12 15:55:22 PST
Created attachment 220988 [details] Patch
WebKit Commit Bot
Comment 2 2014-01-12 15:56:51 PST
Attachment 220988 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSStringRef.cpp', u'Source/JavaScriptCore/API/JSStringRefCF.cpp', u'Source/JavaScriptCore/API/OpaqueJSString.h', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/inspector/InspectorValues.cpp', u'Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp', u'Source/JavaScriptCore/runtime/StringPrototype.cpp', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/text/AtomicString.cpp', u'Source/WTF/wtf/text/AtomicString.h', u'Source/WTF/wtf/text/Base64.cpp', u'Source/WTF/wtf/text/StringBuilder.h', u'Source/WTF/wtf/text/StringImpl.cpp', u'Source/WTF/wtf/text/StringImpl.h', u'Source/WTF/wtf/text/WTFString.cpp', u'Source/WTF/wtf/text/WTFString.h', u'Source/WebCore/ChangeLog', u'Source/WebCore/Modules/indexeddb/IDBKeyPath.cpp', u'Source/WebCore/Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp', u'Source/WebCore/accessibility/AccessibilityObject.cpp', u'Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm', u'Source/WebCore/bindings/js/SerializedScriptValue.cpp', u'Source/WebCore/dom/CharacterData.cpp', u'Source/WebCore/dom/Document.cpp', u'Source/WebCore/editing/Editor.cpp', u'Source/WebCore/editing/TextCheckingHelper.cpp', u'Source/WebCore/editing/TextCheckingHelper.h', u'Source/WebCore/editing/TextIterator.cpp', u'Source/WebCore/editing/TextIterator.h', u'Source/WebCore/editing/VisiblePosition.cpp', u'Source/WebCore/editing/VisibleUnits.cpp', u'Source/WebCore/fileapi/WebKitBlobBuilder.cpp', u'Source/WebCore/html/FormDataList.cpp', u'Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp', u'Source/WebCore/html/parser/HTMLParserIdioms.cpp', u'Source/WebCore/html/parser/HTMLTreeBuilder.cpp', u'Source/WebCore/loader/appcache/ManifestParser.cpp', u'Source/WebCore/page/ContentSecurityPolicy.cpp', u'Source/WebCore/page/PageSerializer.cpp', u'Source/WebCore/platform/Length.cpp', u'Source/WebCore/platform/LinkHash.cpp', u'Source/WebCore/platform/SharedBuffer.cpp', u'Source/WebCore/platform/URL.cpp', u'Source/WebCore/platform/graphics/StringTruncator.cpp', u'Source/WebCore/platform/graphics/TextRun.h', u'Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm', u'Source/WebCore/platform/network/FormDataBuilder.cpp', u'Source/WebCore/platform/sql/SQLiteStatement.cpp', u'Source/WebCore/platform/text/DecodeEscapeSequences.h', u'Source/WebCore/platform/text/TextBreakIterator.cpp', u'Source/WebCore/platform/text/TextBreakIteratorICU.cpp', u'Source/WebCore/platform/text/TextCodecICU.cpp', u'Source/WebCore/rendering/RenderBlock.cpp', u'Source/WebCore/rendering/RenderListMarker.cpp', u'Source/WebCore/rendering/RenderText.cpp', u'Source/WebCore/rendering/RenderText.h', u'Source/WebCore/rendering/line/BreakingContextInlineHeaders.h', u'Source/WebCore/rendering/svg/SVGInlineTextBox.cpp', u'Source/WebCore/rendering/svg/SVGTextLayoutAttributesBuilder.cpp', u'Source/WebCore/rendering/svg/SVGTextLayoutEngine.cpp', u'Source/WebCore/rendering/svg/SVGTextMetrics.cpp', u'Source/WebCore/rendering/svg/SVGTextMetricsBuilder.cpp', u'Source/WebCore/svg/SVGAngle.cpp', u'Source/WebCore/svg/SVGAnimateMotionElement.cpp', u'Source/WebCore/svg/SVGAnimationElement.cpp', u'Source/WebCore/svg/SVGFitToViewBox.cpp', u'Source/WebCore/svg/SVGFontData.cpp', u'Source/WebCore/svg/SVGGlyphMap.h', u'Source/WebCore/svg/SVGGlyphRefElement.cpp', u'Source/WebCore/svg/SVGLength.cpp', u'Source/WebCore/svg/SVGLengthList.cpp', u'Source/WebCore/svg/SVGNumberList.cpp', u'Source/WebCore/svg/SVGParserUtilities.cpp', u'Source/WebCore/svg/SVGPreserveAspectRatio.cpp', u'Source/WebCore/svg/SVGStringList.cpp', u'Source/WebCore/svg/SVGTransformList.cpp', u'Source/WebCore/svg/SVGTransformable.cpp', u'Source/WebCore/svg/SVGViewSpec.cpp', u'Source/WebCore/svg/SVGZoomAndPan.h', u'Source/WebCore/xml/XMLHttpRequest.cpp', u'Source/WebCore/xml/XSLStyleSheetLibxslt.cpp', u'Source/WebCore/xml/XSLTUnicodeSort.cpp', u'Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/History/BinaryPropertyList.cpp', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Shared/APIString.h', u'Source/WebKit2/UIProcess/WebPageProxy.cpp', u'Source/WebKit2/WebProcess/WebPage/EncoderAdapter.cpp', '--commit-queue']" exit_code: 1 ERROR: Source/JavaScriptCore/API/JSStringRef.cpp:113: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 1 in 89 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 3 2014-01-12 17:45:43 PST
Comment on attachment 220988 [details] Patch rs=me
Darin Adler
Comment 4 2014-01-12 18:25:41 PST
Committed r161851: <http://trac.webkit.org/changeset/161851>
Note You need to log in before you can comment on or make changes to this bug.