Bug 126856 – TextBreakIterator's should support Latin-1 for all iterator types

• Component: Text
• Status: RESOLVED FIXED

[Sam Weinig]

TextBreakIterator's should support Latin-1 for all iterator types so we don't need to convert to UTF-16 unnecessarily.

[Sam Weinig]

Created attachment 220987 [details]
Part 1

[Darin Adler]

Comment on attachment 220987 [details]
Part 1

View in context: https://bugs.webkit.org/attachment.cgi?id=220987&action=review

> Source/WebCore/platform/text/TextBreakIteratorICU.cpp:61
> +static TextBreakIterator* setTextForIterator(TextBreakIterator* iterator, StringView string)

Should this take a reference instead of a pointer?

> Source/WebCore/platform/text/TextBreakIteratorICU.cpp:77
> +        ubrk_setUText(reinterpret_cast<UBreakIterator*>(iterator), text, &setTextStatus);

I’d like to see a helper function so we have only one reinterpret_cast instead of many. Or maybe just transition to use UBreakIterator directly since we don’t need a non-ICU abstraction for this.

> Source/WebCore/platform/text/TextBreakIteratorICU.cpp:143
> +TextBreakIterator* wordBreakIterator(const UChar* buffer, int length)

Why not make this take a StringView too?

> Source/WebCore/platform/text/TextBreakIteratorICU.cpp:152
> +TextBreakIterator* sentenceBreakIterator(const UChar* buffer, int length)

And this.

> Source/WebCore/platform/text/TextBreakIteratorICU.cpp:161
> +TextBreakIterator* cursorMovementIterator(const UChar* buffer, int length)

And this.

> Source/WebCore/platform/text/TextBreakIteratorICU.cpp:267
> +void releaseLineBreakIterator(TextBreakIterator* iterator)

Reference?

> Source/WebCore/platform/text/TextBreakIteratorICU.cpp:356
> +// Iterator implemenation.
> +
> +int textBreakFirst(TextBreakIterator* iterator)
> +{
> +    return ubrk_first(reinterpret_cast<UBreakIterator*>(iterator));
> +}
> +
> +int textBreakLast(TextBreakIterator* iterator)
> +{
> +    return ubrk_last(reinterpret_cast<UBreakIterator*>(iterator));
> +}
> +
> +int textBreakNext(TextBreakIterator* iterator)
> +{
> +    return ubrk_next(reinterpret_cast<UBreakIterator*>(iterator));
> +}
> +
> +int textBreakPrevious(TextBreakIterator* iterator)
> +{
> +    return ubrk_previous(reinterpret_cast<UBreakIterator*>(iterator));
> +}
> +
> +int textBreakPreceding(TextBreakIterator* iterator, int pos)
> +{
> +    return ubrk_preceding(reinterpret_cast<UBreakIterator*>(iterator), pos);
> +}
> +
> +int textBreakFollowing(TextBreakIterator* iterator, int pos)
> +{
> +    return ubrk_following(reinterpret_cast<UBreakIterator*>(iterator), pos);
> +}
> +
> +int textBreakCurrent(TextBreakIterator* iterator)
> +{
> +    return ubrk_current(reinterpret_cast<UBreakIterator*>(iterator));
> +}
> +
> +bool isTextBreak(TextBreakIterator* iterator, int position)
> +{
> +    return ubrk_isBoundary(reinterpret_cast<UBreakIterator*>(iterator), position);
> +}
> +
> +bool isWordTextBreak(TextBreakIterator* iterator)
> +{
> +    int ruleStatus = ubrk_getRuleStatus(reinterpret_cast<UBreakIterator*>(iterator));
> +    return ruleStatus != UBRK_WORD_NONE;
>  }

This should all just go. It’s a wrapper that we don’t need.

> Source/WebCore/platform/text/icu/UTextProviderLatin1.cpp:46
> +    0, 0, 0,

Some nullptr maybe?

> Source/WebCore/platform/text/icu/UTextProviderLatin1.cpp:52
> +    0,
> +    0,

Some nullptr maybe?

> Source/WebCore/platform/text/icu/UTextProviderLatin1.cpp:56
> +    0, 0, 0

Some nullptr maybe?

> Source/WebCore/platform/text/icu/UTextProviderLatin1.cpp:64
> +        return 0;

nullptr

> Source/WebCore/platform/text/icu/UTextProviderLatin1.cpp:72
> +    /* Point at the same position, but with an empty buffer */

Maybe // instead of /* comment? In this whole file perhaps.

> Source/WebCore/platform/text/icu/UTextProviderLatin1.cpp:98
> +            uText->chunkOffset = (int32_t)(index - uText->chunkNativeStart);

static_cast?

> Source/WebCore/platform/text/icu/UTextProviderLatin1.cpp:109
> +            uText->chunkOffset = (int32_t)(index - uText->chunkNativeStart);

static_cast?

> Source/WebCore/platform/text/icu/UTextProviderLatin1.cpp:206
> +    uText->context = 0;

nullptr?

> Source/WebCore/platform/text/icu/UTextProviderLatin1.cpp:224
> +    text->a = (int64_t)length;

static_cast? no cast at all?

> Source/WebCore/platform/text/icu/UTextProviderLatin1.h:42
> +UText* openLatin1UTextProvider(UTextWithBuffer* utWithBuffer, const LChar* string, unsigned length, UErrorCode* status);
> +UText* openLatin1ContextAwareUTextProvider(UTextWithBuffer* utWithBuffer, const LChar* string, unsigned length, const UChar* priorContext, int priorContextLength, UErrorCode* status);

utWithBuffer and status argument names should be omitted.

> Source/WebCore/platform/text/icu/UTextProviderUTF16.cpp:43
> +    0, 0, 0,

nullptr?

> Source/WebCore/platform/text/icu/UTextProviderUTF16.cpp:48
> +    0, 0, 0, 0,

nullptr?

> Source/WebCore/platform/text/icu/UTextProviderUTF16.cpp:50
> +    0, 0, 0,

nullptr?

[Sam Weinig]

> > Source/WebCore/platform/text/TextBreakIteratorICU.cpp:77
> > +        ubrk_setUText(reinterpret_cast<UBreakIterator*>(iterator), text, &setTextStatus);
> 
> I’d like to see a helper function so we have only one reinterpret_cast instead of many. Or maybe just transition to use UBreakIterator directly since we don’t need a non-ICU abstraction for this.

I'll do that in a follow up.

> > Source/WebCore/platform/text/TextBreakIteratorICU.cpp:143
> > +TextBreakIterator* wordBreakIterator(const UChar* buffer, int length)
> 
> Why not make this take a StringView too?
> 
> > Source/WebCore/platform/text/TextBreakIteratorICU.cpp:152
> > +TextBreakIterator* sentenceBreakIterator(const UChar* buffer, int length)
> 
> And this.
> 
> > Source/WebCore/platform/text/TextBreakIteratorICU.cpp:161
> > +TextBreakIterator* cursorMovementIterator(const UChar* buffer, int length)
> 
> And this.

That is step 2.

[Sam Weinig]

Committed r161844: <http://trac.webkit.org/changeset/161844>

[Sam Weinig]

Created attachment 221063 [details]
Patch

[WebKit Commit Bot]

Attachment 221063 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/PlatformGTK.cmake', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/dom/CharacterData.cpp', u'Source/WebCore/editing/TextCheckingHelper.cpp', u'Source/WebCore/editing/VisibleUnits.cpp', u'Source/WebCore/platform/graphics/StringTruncator.cpp', u'Source/WebCore/platform/graphics/mac/ComplexTextController.cpp', u'Source/WebCore/platform/text/TextAllInOne.cpp', u'Source/WebCore/platform/text/TextBoundaries.cpp', u'Source/WebCore/platform/text/TextBreakIterator.cpp', u'Source/WebCore/platform/text/TextBreakIterator.h', u'Source/WebCore/platform/text/TextBreakIteratorICU.cpp', u'Source/WebCore/rendering/RenderText.cpp', u'Source/WebCore/rendering/break_lines.h', u'Source/WebKit/ios/ChangeLog', u'Source/WebKit/ios/Misc/WebNSStringDrawing.mm', u'Source/WebKit/ios/Misc/WebUIKitSupport.mm', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/UIProcess/efl/TextCheckerEfl.cpp', '--commit-queue']" exit_code: 1
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:215:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:223:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:224:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:225:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:226:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:227:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:228:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:229:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:230:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:231:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:232:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:233:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:234:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:235:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:236:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:237:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:238:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:239:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:240:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:241:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:242:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:243:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:244:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:245:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:246:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:258:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:259:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:260:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:261:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:262:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:263:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:264:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:265:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:275:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:276:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:277:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:278:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:279:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:280:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:281:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:282:  One space before end of line comments  [whitespace/comments] [5]
Total errors found: 41 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EFL EWS Bot]

Comment on attachment 221063 [details]
Patch

Attachment 221063 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/5738164891156480

[EFL EWS Bot]

Comment on attachment 221063 [details]
Patch

Attachment 221063 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/6641037883736064

[kov's GTK+ EWS bot]

Comment on attachment 221063 [details]
Patch

Attachment 221063 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/5595110804815872

[Sam Weinig]

Created attachment 221228 [details]
Patch

[WebKit Commit Bot]

Attachment 221228 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/PlatformGTK.cmake', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/dom/CharacterData.cpp', u'Source/WebCore/editing/TextCheckingHelper.cpp', u'Source/WebCore/editing/VisibleUnits.cpp', u'Source/WebCore/page/TouchAdjustment.cpp', u'Source/WebCore/platform/graphics/StringTruncator.cpp', u'Source/WebCore/platform/graphics/mac/ComplexTextController.cpp', u'Source/WebCore/platform/text/TextAllInOne.cpp', u'Source/WebCore/platform/text/TextBoundaries.cpp', u'Source/WebCore/platform/text/TextBreakIterator.cpp', u'Source/WebCore/platform/text/TextBreakIterator.h', u'Source/WebCore/platform/text/TextBreakIteratorICU.cpp', u'Source/WebCore/platform/text/enchant/TextCheckerEnchant.cpp', u'Source/WebCore/rendering/RenderText.cpp', u'Source/WebCore/rendering/break_lines.h', u'Source/WebKit/ios/ChangeLog', u'Source/WebKit/ios/Misc/WebNSStringDrawing.mm', u'Source/WebKit/ios/Misc/WebUIKitSupport.mm', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/UIProcess/efl/TextCheckerEfl.cpp', '--commit-queue']" exit_code: 1
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:215:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:223:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:224:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:225:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:226:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:227:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:228:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:229:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:230:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:231:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:232:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:233:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:234:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:235:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:236:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:237:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:238:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:239:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:240:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:241:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:242:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:243:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:244:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:245:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:246:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:258:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:259:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:260:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:261:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:262:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:263:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:264:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:265:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:275:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:276:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:277:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:278:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:279:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:280:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:281:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:282:  One space before end of line comments  [whitespace/comments] [5]
Total errors found: 41 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Sam Weinig]

Comment on attachment 221228 [details]
Patch

I'm going to break this up.

[Sam Weinig]

Created attachment 221324 [details]
Patch

[WebKit Commit Bot]

Attachment 221324 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/PlatformGTK.cmake', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/platform/text/TextBreakIterator.cpp', u'Source/WebCore/platform/text/TextBreakIteratorICU.cpp', '--commit-queue']" exit_code: 1
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:174:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:182:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:183:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:184:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:185:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:186:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:187:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:188:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:189:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:190:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:191:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:192:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:193:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:194:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:195:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:196:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:197:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:198:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:199:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:200:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:201:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:202:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:203:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:204:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:205:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:217:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:218:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:219:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:220:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:221:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:222:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:223:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:224:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:234:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:235:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:236:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:237:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:238:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:239:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:240:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:241:  One space before end of line comments  [whitespace/comments] [5]
Total errors found: 41 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Sam Weinig]

Committed r162109: <http://trac.webkit.org/changeset/162109>

[Sam Weinig]

One more patch to go before we can close this guy.

[Sam Weinig]

Created attachment 221329 [details]
Patch

[EFL EWS Bot]

Comment on attachment 221329 [details]
Patch

Attachment 221329 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/5492986548846592

[EFL EWS Bot]

Comment on attachment 221329 [details]
Patch

Attachment 221329 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/5889102792622080

[Build Bot]

Comment on attachment 221329 [details]
Patch

Attachment 221329 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6672203105959936

[kov's GTK+ EWS bot]

Comment on attachment 221329 [details]
Patch

Attachment 221329 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/5205691354578944

[Sam Weinig]

Created attachment 221331 [details]
Patch

[EFL EWS Bot]

Comment on attachment 221331 [details]
Patch

Attachment 221331 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/6480987403845632

[EFL EWS Bot]

Comment on attachment 221331 [details]
Patch

Attachment 221331 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/6291626053861376

[kov's GTK+ EWS bot]

Comment on attachment 221331 [details]
Patch

Attachment 221331 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/4615102749736960

[Sam Weinig]

Created attachment 221438 [details]
Patch

[Anders Carlsson]

Comment on attachment 221438 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221438&action=review

> Source/WebCore/ChangeLog:9
> +        now unnecessary up-conversion to UTF-16 in the process.

up-conversions?

[Sam Weinig]

Committed r162184: <http://trac.webkit.org/changeset/162184>

[Alexey Proskuryakov]

This change made multiple tests crash on Windows, filed bug 127408.