| Summary: | Remove String::deprecatedCharacters | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Darin Adler <darin> |
| Component: | WebKit Misc. | Assignee: | Darin Adler <darin> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | andersca, buildbot, commit-queue, rniwa |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
| Bug Depends on: | 126870, 130197, 130304, 130305, 130317, 130318, 130323, 130515, 130602 | ||
| Bug Blocks: | |||
| Attachments: | |||
|
Description
Darin Adler
2014-01-12 14:35:52 PST
Created attachment 220985 [details]
Patch
Comment on attachment 220985 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220985&action=review > Source/WebCore/editing/CompositeEditCommand.cpp:674 > for (unsigned i = 0; i < text.length(); ++i) { > - if (!isWhitespace(text.characters()[i])) > + if (!isWhitespace(text[i])) > return false; > } > - > return true; > } Could this use isAllSpecialCharacters? Committed r161840: <http://trac.webkit.org/changeset/161840> Re-opened since this is blocked by bug 126870 Comment on attachment 220985 [details] Patch Attachment 220985 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6520798932107264 New failing tests: editing/execCommand/indent-pre-list.html editing/execCommand/indent-pre-paragraphs.html editing/deleting/2610675-1.html editing/deleting/merge-whitespace-pre.html fast/forms/textarea-paste-newline.html editing/execCommand/format-block-multiple-paragraphs-in-pre.html editing/pasteboard/copy-image-with-alt-text.html editing/input/scroll-to-edge-if-line-break-at-end-of-document-textarea.html editing/execCommand/format-block-multiple-paragraphs.html editing/pasteboard/copy-paste-pre-line-content.html editing/execCommand/indent-pre.html Created attachment 221010 [details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-15 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Created attachment 227526 [details]
Patch
Created attachment 227532 [details]
Patch
Comment on attachment 227532 [details] Patch Attachment 227532 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6313068174770176 New failing tests: http/tests/misc/acid3.html fast/loader/stateobjects/state-url-sets-links-visited.html fast/history/nested-visited-test.html fast/history/visited-link-background-color.html fast/history/multiple-classes-visited.html platform/mac/accessibility/search-predicate.html fast/history/sibling-visited-test.html fast/history/self-is-visited.html Created attachment 227537 [details]
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-06 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Comment on attachment 227532 [details] Patch Attachment 227532 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6495832186552320 New failing tests: http/tests/misc/acid3.html fast/loader/stateobjects/state-url-sets-links-visited.html fast/history/nested-visited-test.html fast/history/visited-link-background-color.html fast/history/multiple-classes-visited.html fast/history/sibling-visited-test.html fast/history/self-is-visited.html Created attachment 227539 [details]
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-10 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 227532 [details] Patch Attachment 227532 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5330893174472704 New failing tests: http/tests/misc/acid3.html fast/loader/stateobjects/state-url-sets-links-visited.html fast/history/nested-visited-test.html fast/history/visited-link-background-color.html fast/history/multiple-classes-visited.html platform/mac/accessibility/search-predicate.html fast/history/sibling-visited-test.html fast/history/self-is-visited.html Created attachment 227540 [details]
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-03 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Comment on attachment 227532 [details] Patch Attachment 227532 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6094294083436544 New failing tests: http/tests/misc/acid3.html fast/loader/stateobjects/state-url-sets-links-visited.html fast/history/nested-visited-test.html fast/history/visited-link-background-color.html fast/history/multiple-classes-visited.html fast/history/sibling-visited-test.html fast/history/self-is-visited.html Created attachment 227543 [details]
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-16 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 227532 [details] Patch Attachment 227532 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5112592603283456 New failing tests: http/tests/misc/acid3.html fast/loader/stateobjects/state-url-sets-links-visited.html fast/history/nested-visited-test.html fast/history/visited-link-background-color.html fast/history/multiple-classes-visited.html platform/mac/accessibility/search-predicate.html fast/history/sibling-visited-test.html fast/history/self-is-visited.html Created attachment 227545 [details]
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-01 Port: mac-mountainlion Platform: Mac OS X 10.8.5
There was a mistake in LinkHash.cpp that caused all those visited-link tests to fail. I have that fixed now. The mysterious failure is platform/mac/accessibility/search-predicate.html; looking into that next. Created attachment 227550 [details]
Patch
Created attachment 227554 [details]
Patch
Created attachment 227556 [details]
Patch
Comment on attachment 227556 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=227556&action=review > Source/WebCore/platform/URL.cpp:1501 > +static bool containsOnlyASCII(StringView string) > +{ > + if (string.is8Bit()) > + return charactersAreAllASCII(string.characters8(), string.length()); > + return charactersAreAllASCII(string.characters16(), string.length()); > +} We should probably add a version of charactersAreAllASCII() that takes a StringView. Committed r166120: <http://trac.webkit.org/changeset/166120> |