| Summary: | REGRESSION(r160806): line-height is not applied when only present in :link style. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Andreas Kling <kling> | ||||||
| Component: | CSS | Assignee: | Andreas Kling <kling> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | allan.jensen, commit-queue, esprehn+autocc, glenn, gyuyoung.kim, kling, macpherson, menard | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Andreas Kling
2014-01-12 04:33:35 PST
Created attachment 220966 [details]
Patch
Created attachment 220967 [details]
Patch
Comment on attachment 220967 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220967&action=review > Source/WebCore/css/StyleResolver.cpp:4255 > + if (auto value = state.style()->insideLink() == NotInsideLink ? cssValue[0] : cssValue[SelectorChecker::MatchLink]) cssValue indexing by LinkMatchMask is pretty incomprehensible. It might be better to just have separate variables (cssValue/linkCSSValue/visitedCSSValue or similar). (In reply to comment #3) > (From update of attachment 220967 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=220967&action=review > > > Source/WebCore/css/StyleResolver.cpp:4255 > > + if (auto value = state.style()->insideLink() == NotInsideLink ? cssValue[0] : cssValue[SelectorChecker::MatchLink]) > > cssValue indexing by LinkMatchMask is pretty incomprehensible. It might be better to just have separate variables (cssValue/linkCSSValue/visitedCSSValue or similar). Yeah, I agree. Let's keep this fix surgical and sort that in a separate change though. Comment on attachment 220967 [details] Patch Clearing flags on attachment: 220967 Committed r161814: <http://trac.webkit.org/changeset/161814> All reviewed patches have been landed. Closing bug. |