Bug 126820

Summary:

Extract the FormatConverter class out of GraphicsContext3D.cpp and into its own file

Product:

WebKit

Reporter:

Sam Weinig <sam>

Component:

New Bugs

Assignee:

Sam Weinig <sam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bunhere, commit-queue, dino, gyuyoung.kim, kondapallykalyan, rakuco, roger_fong

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Sam Weinig

Reported 2014-01-11 11:43:38 PST

Extract the FormatConverter class out of GraphicsContext3D.cpp and into its own file

Attachments
Patch (344.02 KB, patch) 2014-01-11 11:45 PST, Sam Weinig	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Sam Weinig

Comment 1 2014-01-11 11:45:16 PST

Created attachment 220942 [details] Patch

WebKit Commit Bot

Comment 2 2014-01-11 11:46:04 PST

Attachment 220942 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/platform/graphics/FormatConverter.cpp', u'Source/WebCore/platform/graphics/FormatConverter.h', u'Source/WebCore/platform/graphics/GraphicsContext3D.cpp', u'Source/WebCore/platform/graphics/GraphicsContext3D.h', '--commit-queue']" exit_code: 1 ERROR: Source/WebCore/platform/graphics/FormatConverter.cpp:32: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/FormatConverter.cpp:187: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/platform/graphics/FormatConverter.cpp:199: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/platform/graphics/FormatConverter.cpp:211: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/platform/graphics/FormatConverter.cpp:223: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/platform/graphics/FormatConverter.cpp:237: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/platform/graphics/FormatConverter.cpp:256: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/platform/graphics/FormatConverter.cpp:275: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/platform/graphics/FormatConverter.cpp:295: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/platform/graphics/FormatConverter.cpp:311: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/platform/graphics/FormatConverter.cpp:323: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/platform/graphics/FormatConverter.cpp:335: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/platform/graphics/FormatConverter.cpp:347: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/platform/graphics/FormatConverter.cpp:360: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/platform/graphics/FormatConverter.cpp:373: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/platform/graphics/FormatConverter.cpp:437: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/platform/graphics/FormatConverter.cpp:449: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/platform/graphics/FormatConverter.cpp:461: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/platform/graphics/FormatConverter.cpp:473: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/platform/graphics/FormatConverter.cpp:495: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/platform/graphics/FormatConverter.cpp:504: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/platform/graphics/FormatConverter.cpp:513: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/platform/graphics/FormatConverter.cpp:525: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/platform/graphics/FormatConverter.cpp:536: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/platform/graphics/FormatConverter.cpp:546: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/platform/graphics/FormatConverter.cpp:559: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/platform/graphics/FormatConverter.cpp:571: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/platform/graphics/FormatConverter.cpp:582: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/platform/graphics/FormatConverter.cpp:598: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/platform/graphics/FormatConverter.cpp:619: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/platform/graphics/FormatConverter.cpp:636: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/platform/graphics/FormatConverter.cpp:655: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/platform/graphics/FormatConverter.cpp:657: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebCore/platform/graphics/FormatConverter.cpp:667: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/platform/graphics/FormatConverter.cpp:673: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebCore/platform/graphics/FormatConverter.cpp:684: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/platform/graphics/FormatConverter.cpp:690: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebCore/platform/graphics/FormatConverter.cpp:703: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/platform/graphics/FormatConverter.cpp:705: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebCore/platform/graphics/FormatConverter.cpp:715: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/platform/graphics/FormatConverter.cpp:721: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebCore/platform/graphics/FormatConverter.cpp:732: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/platform/graphics/FormatConverter.cpp:738: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebCore/platform/graphics/FormatConverter.cpp:751: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/platform/graphics/FormatConverter.cpp:753: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebCore/platform/graphics/FormatConverter.cpp:762: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/platform/graphics/FormatConverter.cpp:768: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebCore/platform/graphics/FormatConverter.cpp:778: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/platform/graphics/FormatConverter.cpp:784: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebCore/platform/graphics/FormatConverter.cpp:793: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/platform/graphics/FormatConverter.cpp:804: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/platform/graphics/FormatConverter.cpp:816: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/platform/graphics/FormatConverter.cpp:834: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/platform/graphics/FormatConverter.cpp:847: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/platform/graphics/FormatConverter.cpp:860: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/platform/graphics/FormatConverter.cpp:869: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/platform/graphics/FormatConverter.cpp:878: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/platform/graphics/FormatConverter.cpp:888: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/platform/graphics/FormatConverter.cpp:898: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/platform/graphics/FormatConverter.cpp:908: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/platform/graphics/FormatConverter.cpp:919: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/platform/graphics/FormatConverter.cpp:1248: Declaration has space between type name and * in const SrcType *srcRowStart [whitespace/declaration] [3] ERROR: Source/WebCore/platform/graphics/FormatConverter.h:28: Header file should not contain WebCore config.h. Should be: alphabetically sorted. [build/include_order] [4] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.cpp:149: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.cpp:200: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.cpp:244: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.cpp:281: Omit int when using unsigned [runtime/unsigned] [1] Total errors found: 67 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Commit Bot

Comment 3 2014-01-11 14:52:36 PST

Comment on attachment 220942 [details] Patch Clearing flags on attachment: 220942 Committed r161783: <http://trac.webkit.org/changeset/161783>

WebKit Commit Bot

Comment 4 2014-01-11 14:52:38 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.