Bug 126801

Summary: Move progress tracking functions from FrameLoaderClient to a new ProgressTrackerClient
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: bunhere, cdumez, commit-queue, gyuyoung.kim, japhet, rakuco
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch sam: review+

Anders Carlsson
Reported 2014-01-10 18:19:21 PST
Move progress tracking functions from FrameLoaderClient to a new ProgressTrackerClient
Attachments
Patch (32.21 KB, patch)
2014-01-10 18:22 PST, Anders Carlsson 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2014-01-10 18:22:21 PST
Created attachment 220915 [details] Patch
WebKit Commit Bot
Comment 2 2014-01-10 18:24:47 PST
Attachment 220915 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/loader/EmptyClients.cpp', u'Source/WebCore/loader/EmptyClients.h', u'Source/WebCore/loader/FrameLoaderClient.h', u'Source/WebCore/loader/ProgressTracker.cpp', u'Source/WebCore/loader/ProgressTracker.h', u'Source/WebCore/loader/ProgressTrackerClient.h', u'Source/WebCore/page/Page.cpp', u'Source/WebCore/page/Page.h', u'Source/WebKit/efl/ChangeLog', u'Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.h', u'Source/WebKit/efl/ewk/ewk_view.cpp', u'Source/WebKit/gtk/ChangeLog', u'Source/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.h', u'Source/WebKit/gtk/webkit/webkitwebview.cpp', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.h', u'Source/WebKit/mac/WebView/WebView.mm', u'Source/WebKit/win/ChangeLog', u'Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.h', u'Source/WebKit/win/WebView.cpp', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.h', u'Source/WebKit2/WebProcess/WebPage/WebPage.cpp', '--commit-queue']" exit_code: 1 ERROR: Source/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.h:46: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 27 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 3 2014-01-10 22:28:57 PST
Committed r161744: <http://trac.webkit.org/changeset/161744>
Note You need to log in before you can comment on or make changes to this bug.