Web Inspector: Switching tabs to window with inspector open prohibits typing into console

• Component: Web Inspector
• Status: RESOLVED FIXED

[Jonathan Wells]

There is an issue with the text input field in the console. In many situations, switching back to a window with the console open, clicking into the console text entry field, then typing results in no text being entered. To reproduce:

1. Open Safari using the nightly build to a blank page.
2. Hit Option-Command-C to open the console
3. Enter a command to confirm the field currently works.
4. Hit Command-T to open a new tab.
5. Hit Shift-Command-[ to move back to the first tab.
6. Click inside the console entry field.
7. Type a key other than Tab or Delete. 

A key other than these will not work.

[Radar WebKit Bug Importer]

<rdar://problem/15798159>

[Ryosuke Niwa]

Created attachment 249396 [details]
Fixes the bug

[Anders Carlsson]

Comment on attachment 249396 [details]
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=249396&action=review

> Source/WebKit2/UIProcess/WebPageProxy.h:396
> +    void updateFocusAppearance();

I think this should have a more descriptive name that indicates that it restores the selection.

[Ryosuke Niwa]

(In reply to comment #3)
> Comment on attachment 249396 [details]
> Fixes the bug
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=249396&action=review
> 
> > Source/WebKit2/UIProcess/WebPageProxy.h:396
> > +    void updateFocusAppearance();
> 
> I think this should have a more descriptive name that indicates that it
> restores the selection.

Renamed to restoreSelectionInFocusedEditableElement.

[Ryosuke Niwa]

Committed r181972: <http://trac.webkit.org/changeset/181972>