Bug 126791

Summary:

Web Inspector: CallFrame is missing saveIdentityToCookie, or should be excluded

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Blaze Burg <bburg>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, commit-queue, graouts, joepeck, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
patch	none

Joseph Pecoraro

Reported 2014-01-10 16:27:04 PST

file:///Volumes/Data/Build/Debug/WebInspectorUI.framework/Resources/NavigationSidebarPanel.js:213: CONSOLE ERROR: Error: TreeElement.representedObject is missing a saveIdentityToCookie implementation. WebInspector.CallFrameTreeElement => WebInspector.CallFrame

Attachments
patch (1.50 KB, patch) 2014-01-16 10:06 PST, Blaze Burg	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Joseph Pecoraro

Comment 1 2014-01-10 16:28:09 PST

STEPS TO REPRODUCE: 1. Inspect a page 2. Set a breakpoint 3. Trigger breakpoint. 4. Select a CallFrame tree element in the debugger sidebar 5. Close inspector => exception seen in console

Radar WebKit Bug Importer

Comment 2 2014-01-10 16:28:22 PST

<rdar://problem/15797412>

Radar WebKit Bug Importer

Comment 3 2014-01-10 16:28:26 PST

<rdar://problem/15797403>

Blaze Burg

Comment 4 2014-01-10 16:30:33 PST

This should ignore call frame elements, since (currently) we continue and remove all breakpoints when the inspector is closed.

Blaze Burg

Comment 5 2014-01-16 10:06:18 PST

Created attachment 221388 [details] patch