Summary: | FreeBSD build fixes | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Koop Mast <kwm> | ||||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ajacoutot, andersca, commit-queue, dbates, landry, sam | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 128598 | ||||||||
Attachments: |
|
Description
Koop Mast
2014-01-10 13:45:12 PST
Created attachment 220882 [details]
build fixes
Comment on attachment 220882 [details]
build fixes
set review flag
Comment on attachment 220882 [details] build fixes View in context: https://bugs.webkit.org/attachment.cgi?id=220882&action=review > ChangeLog:10 > + I believe you shouldn't update this file, only the one in Source/WebKit2/Changelog. Created attachment 221543 [details]
Build fixes for FreeBSD
Same patch as before but used Tools/Scripts/prepare-ChangeLog to generate the Changelog.
Comment on attachment 221543 [details] Build fixes for FreeBSD Clearing flags on attachment: 221543 Committed r162513: <http://trac.webkit.org/changeset/162513> All reviewed patches have been landed. Closing bug. Hi. I don't understand this patch. Isn't SIGCLD the same as SIGCHLD? If so then why not s/SIGCLD/SIGCHLD which will work everywhere. That is what we've been using on OpenBSD. Unless I am missing something obvious... (In reply to comment #7) > Hi. > > I don't understand this patch. Isn't SIGCLD the same as SIGCHLD? > If so then why not s/SIGCLD/SIGCHLD which will work everywhere. That is what we've been using on OpenBSD. > Unless I am missing something obvious... Yes... Koop, can you elaborate on why #if'ing out those parts ? We've used this for 2.2: http://www.openbsd.org/cgi-bin/cvsweb/ports/www/webkit/patches/patch-Source_WebKit2_UIProcess_Plugins_unix_PluginProcessProxyUnix_cpp?rev=1.4;content-type=text%2Fplain |