Summary: | [JSC] Revise typed array implementations to match ECMAScript and WebGL Specification | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> | ||||
Component: | JavaScriptCore | Assignee: | Dean Jackson <dino> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bfulgham, commit-queue, dino, fpizlo, ggaren, oliver, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Bug Depends on: | 126803 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Brent Fulgham
2014-01-10 09:00:07 PST
Ken Russel notes that this is true of all of the Typed Array constructors as well. Created attachment 220907 [details]
Patch
Committed r161702: <http://trac.webkit.org/changeset/161702> This change broke four JS tests: ** The following JSC stress test failures have been introduced: jsc-layout-tests.yaml/js/script-tests/typedarray-constructors.js.layout jsc-layout-tests.yaml/js/script-tests/typedarray-constructors.js.layout-no-llint jsc-layout-tests.yaml/js/script-tests/typedarray-constructors.js.layout-no-cjit jsc-layout-tests.yaml/js/script-tests/typedarray-constructors.js.layout-dfg-eager-no-cjit While this is probably expected, it makes the tree red. And also fast/canvas/webgl/data-view-test.html. Re-opened since this is blocked by bug 126803 I think all of these changes are expected, and should have been part of the patch. I'll correct and re-land. Comment on attachment 220907 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220907&action=review > LayoutTests/js/script-tests/typedarray-constructors.js:7 > +shouldNotThrow("new Int8Array()"); It turns out that 'shouldNotThrow' is NOT part of "standalone-pre.js", which is what's used for the JSC stress tests. Committed r161789: <http://trac.webkit.org/changeset/161789> |