Bug 126681

Summary: Correctly fill loaded and total attribute values of XHR ProgressEvent events
Product: WebKit Reporter: youenn fablet <youennf>
Component: XMLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, youennf
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch to fix assertion issues on top of 120828
none
Patch 120828 with fix of assertion issues
none
Updated change logs none

youenn fablet
Reported 2014-01-08 23:40:17 PST
This is a follow-up on bug 120828
Attachments
Patch to fix assertion issues on top of 120828 (3.01 KB, patch)
2014-01-09 07:06 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch 120828 with fix of assertion issues (35.16 KB, patch)
2014-01-09 07:15 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Updated change logs (37.21 KB, patch)
2014-01-10 00:30 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2014-01-08 23:43:15 PST
I forgot in last patch of bug 120828 to add loadend event as a valid event in the assertions within XMLHttpRequestUpload::dispatchProgressEvent and XMLHttpRequestProgressEventThrottle::dispatchProgressEvent. Will fix that asap.
youenn fablet
Comment 2 2014-01-09 07:06:00 PST
Created attachment 220728 [details] Patch to fix assertion issues on top of 120828
youenn fablet
Comment 3 2014-01-09 07:15:19 PST
Created attachment 220731 [details] Patch 120828 with fix of assertion issues This patch merges bug 120828 patch with the assertion fix that is uploaded of bug 126681. http/tests and dom/svg tests pass with the patch in debug mode, gtk port
Alexey Proskuryakov
Comment 4 2014-01-09 09:25:29 PST
Comment on attachment 220731 [details] Patch 120828 with fix of assertion issues View in context: https://bugs.webkit.org/attachment.cgi?id=220731&action=review > Source/WebCore/ChangeLog:8 > + Fixed assertions over patch in https://bugs.webkit.org/show_bug.cgi?id=120828 Looks fine, however the ChangeLog should have a complete explanation, the discussion of something that was rolled out is confusing. In other words, I'd just use the same preamble as in the original patch here.
youenn fablet
Comment 5 2014-01-10 00:30:11 PST
Created attachment 220815 [details] Updated change logs
WebKit Commit Bot
Comment 6 2014-01-10 13:18:16 PST
Comment on attachment 220815 [details] Updated change logs Clearing flags on attachment: 220815 Committed r161668: <http://trac.webkit.org/changeset/161668>
WebKit Commit Bot
Comment 7 2014-01-10 13:18:18 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.