Bug 12664
Summary: | REGRESSION: After navigating between pages, returning back to a previously cached page is displayed as blank in window | ||
---|---|---|---|
Product: | WebKit | Reporter: | Maciej Stachowiak <mjs> |
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | dev+webkit, koivisto, mitz |
Priority: | P1 | Keywords: | InRadar |
Version: | 420+ | ||
Hardware: | Mac | ||
OS: | OS X 10.4 |
Maciej Stachowiak
2007-01-27 10:29:39 Chris Petersen:
* SUMMARY
With Safari-Leopard-Production-19168-11910.tar.gz, I have encountered a problem where returning back to a previously cached page fails to display it' content. Basically, the page is empty.
I have tracked this regression to http://trac.webkit.org/projects/webkit/changeset/18541
* STEPS TO REPRODUCE
1. With TOT (Tiger) or TOT (Leopard), go to http://www.apple.com/startpage/
2. After page loads, type bogus URL in the Address URL field and attempt to go to it.
3. You should get a "Safari can't find the server" page. Now press the back toolbar icon to return to previous page ( http://www.apple.com/startpage/ )
4. After http://www.apple.com/startpage/ loads, press the forward toolbar icon
5. After "Safari can't find the server" page appears, press the back toolbar icon once again
6. Notice the page for http://www.apple.com/startpage/ is blank
* RESULTS
Returning back to the previous cached page should display it's contents but doesn't
* REGRESSION
Yes, since the doesn't occur in stock Leopard9A348.
2007-01-29 11:44:02 Brady Eidson:
This has already made it into our last submission, but I'm still taking a look... if it really requires an error page and this bizarre "back - forward - back" step, I'm not sure its worth of the keyword
2007-01-29 11:44:19 Brady Eidson:
submission blocker, that is - definitely still blocker
2007-01-29 11:58:10 Brady Eidson:
I've confirmed this only happens with error pages
I think we can nuke the submission blocker keyword, but this will be near the top of my list after I'm done with my current feature work.
2007-01-30 20:16:37 Maciej Stachowiak:
In current sources I get an assertion failure:
SSERTION FAILED: dataSource
(/Volumes/Data/mjs/Work/src/Safari/OpenSource/WebKit/WebView/WebHTMLView.mm:3128 -[WebHTMLView setDataSource:])
Program received signal EXC_BAD_ACCESS, Could not access memory.
Reason: KERN_INVALID_ADDRESS at address: 0xbbadbeef
0x0043d337 in -[WebHTMLView setDataSource:] (self=0x16fee850, _cmd=0x90ac026c, dataSource=0x0) at /Volumes/Data/mjs/Work/src/Safari/OpenSource/WebKi\
t/WebView/WebHTMLView.mm:3128
(gdb) bt
#0 0x0043d337 in -[WebHTMLView setDataSource:] (self=0x16fee850, _cmd=0x90ac026c, dataSource=0x0) at /Volumes/Data/mjs/Work/src/Safari/OpenSource/W\
ebKit/WebView/WebHTMLView.mm:3128
warning: internal error: no C/C++ fundamental type 1
#1 0x00491586 in WebFrameLoaderClient::setDocumentViewFromPageCache (this=0x215a520, pageCache=0x17143ce0) at /Volumes/Data/mjs/Work/src/Safari/Ope\
nSource/WebKit/WebCoreSupport/WebFrameLoaderClient.mm:180
#2 0x013c155a in WebCore::FrameLoader::transitionToCommitted (this=0x2820400, pageCache=@0xbfffdd6c) at /Volumes/Data/mjs/Work/src/Safari/OpenSourc\
e/WebCore/loader/FrameLoader.cpp:2352
#3 0x013c1afc in WebCore::FrameLoader::commitProvisionalLoad (this=0x2820400, prpPageCache=@0xbfffde5c) at /Volumes/Data/mjs/Work/src/Safari/OpenSo\
urce/WebCore/loader/FrameLoader.cpp:2285
#4 0x013c527b in WebCore::DocumentLoader::loadFromPageCache (this=0x2945c00, pageCache=@0xbfffde9c) at /Volumes/Data/mjs/Work/src/Safari/OpenSource\
/WebCore/loader/DocumentLoader.cpp:520
#5 0x013b80c6 in WebCore::FrameLoader::loadProvisionalItemFromPageCache (this=0x2820400) at /Volumes/Data/mjs/Work/src/Safari/OpenSource/WebCore/lo\
ader/FrameLoader.cpp:3500
#6 0x013bc217 in WebCore::FrameLoader::continueLoadAfterNavigationPolicy (this=0x2820400, request=@0xbfffdfe4, formState=@0xbfffdf48, shouldContinu\
e=true) at /Volumes/Data/mjs/Work/src/Safari/OpenSource/WebCore/loader/FrameLoader.cpp:3364
2007-02-05 13:15:59 Stephanie Lewis:
By virtue of being Safari Blocker Reviewed, these have been Safari BRB Reviewed
<rdar://problem/4959383>
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
David Kilzer (:ddkilzer)
See also Bug 12361.
David Kilzer (:ddkilzer)
See also Bug 12736.
Anders Carlsson
This was most likely fixed by #19836
Frances Cornwall
*** Bug 12736 has been marked as a duplicate of this bug. ***