Bug 126634

Summary: Move ENABLE_INSPECTOR_SERVER definition to SetupWebKitFeatures.m4
Product: WebKit Reporter: jaybhaskar <jay.bhaskar>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED WONTFIX    
Severity: Normal CC: cgarcia, gustavo, mrobinson, ossy, zan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Move ENABLE_INSPECTOR_SERVER
none
Move ENABLE_INSPECTOR_SERVER definition to SetupWebKitFeatures.m4 ossy: review-

jaybhaskar
Reported 2014-01-08 02:31:03 PST
remove ENABLE_INSPECTOR_SERVER definition from config.h and placing it to SetupWebKitFeatures.m4
Attachments
Move ENABLE_INSPECTOR_SERVER (4.55 KB, text/plain)
2014-01-08 20:40 PST, jaybhaskar 		no flags
Details
Move ENABLE_INSPECTOR_SERVER definition to SetupWebKitFeatures.m4 (2.21 KB, patch)
2014-01-09 03:03 PST, jaybhaskar 		ossy: review-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
jaybhaskar
Comment 1 2014-01-08 20:40:08 PST
Created attachment 220695 [details] Move ENABLE_INSPECTOR_SERVER
jaybhaskar
Comment 2 2014-01-09 03:03:31 PST
Created attachment 220707 [details] Move ENABLE_INSPECTOR_SERVER definition to SetupWebKitFeatures.m4
Martin Robinson
Comment 3 2014-01-09 06:14:28 PST
This seems like the opposite of what we want. Why is it useful to have it in SetupWebKitFeatures.m4 instead of config.h? Your patch also has the side-effect of disabling it on EFL.
Note You need to log in before you can comment on or make changes to this bug.