Bug 126616

Summary:

Web Inspector: Remove InspectorClient::captureScreenshot()

Product:

WebKit

Reporter:

Seokju Kwon <seokju>

Component:

Web Inspector

Assignee:

Seokju Kwon <seokju>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, commit-queue, graouts, joepeck, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Description Seokju Kwon 2014-01-07 21:15:25 PST

Remove leftover mothod as Page.captureScreenshot API was removed in r160202.

Comment 1 Radar WebKit Bug Importer 2014-01-07 21:16:05 PST

<rdar://problem/15769676>

Comment 2 Seokju Kwon 2014-01-07 21:17:01 PST

Created attachment 220591 [details]
Patch

Comment 3 Timothy Hatcher 2014-01-07 21:27:26 PST

Comment on attachment 220591 [details]
Patch

I'm surprised we removed captureScreenshot. Brian Burg was implementing it.

Comment 4 Joseph Pecoraro 2014-01-08 10:09:36 PST

Comment on attachment 220591 [details]
Patch

r=me

This was the port hook to make the port capture a screenshot. Now it is all done in WebCore. This is just a stale line of code from the old, removed, command. The new "snapshot*" commands still exist.

Comment 5 WebKit Commit Bot 2014-01-08 18:08:42 PST

Comment on attachment 220591 [details]
Patch

Clearing flags on attachment: 220591

Committed r161534: <http://trac.webkit.org/changeset/161534>

Comment 6 WebKit Commit Bot 2014-01-08 18:08:45 PST

All reviewed patches have been landed.  Closing bug.