Bug 126589

Summary:

r161364 caused JSC tests regression on non-DFG builds (e.g. C Loop and Windows)

Product:

WebKit

Reporter:

Mark Lam <mark.lam>

Component:

JavaScriptCore

Assignee:

Mark Lam <mark.lam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

fpizlo, ggaren, mhahnenberg, msaboff, oliver

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
the patch.	fpizlo: review+

Description Mark Lam 2014-01-07 12:20:45 PST

The removal of ENABLE(VALUE_PROFILER) in http://trac.webkit.org/changeset/161364 broke all non-DFG builds.  That includes the C loop LLINT and Windows (only baseline JIT) builds.

Per Filip, we'll resolve this by taking the small memory and perf hit on the non-DFG builds, and just do the value profiling work even though the profiling results won't be used by these non-DFG builds.  Patch for the fix coming soon.

ref: <rdar://problem/15758371>

Comment 1 Mark Lam 2014-01-07 12:37:21 PST

Created attachment 220540 [details]
the patch.

Comment 2 Filip Pizlo 2014-01-07 12:42:14 PST

Comment on attachment 220540 [details]
the patch.

r=me

Comment 3 Mark Lam 2014-01-07 12:44:36 PST

Thanks for the review.  Landed in r161446: <http://trac.webkit.org/r161446>.