Bug 126579

Summary: AX: Make roleValue() return DescriptionListRole for <dl> elements
Product: WebKit Reporter: Mario Sanchez Prada <mario>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, jcraig, jdiggs, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch proposal cfleizach: review+

Mario Sanchez Prada
Reported 2014-01-07 06:37:29 PST
At the moment, roleValue() returns ListRole for every list element, even <dl> ones and so we need to check the result of isDescriptionList() in places where we want to know if it's a normal list or a description list (e.g. the ATK wrapper). This bug is about fixing that small issue, according to the comments on bug 125857.
Attachments
Patch proposal (4.30 KB, patch)
2014-01-07 07:15 PST, Mario Sanchez Prada 		cfleizach: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-01-07 06:38:17 PST
<rdar://problem/15762003>
Mario Sanchez Prada
Comment 2 2014-01-07 07:15:46 PST
Created attachment 220523 [details] Patch proposal Attaching patch proposal. In the end, I think no change is needed in the Mac since the code to map DescriptionListRole into NSAccessibilityListRole in role(), and the code to return NSAccessibilityDescriptionListSubrole/NSAccessibilityDefinitionListSubrole is already there and should keep working fine.
Mario Sanchez Prada
Comment 3 2014-01-08 02:54:51 PST
Committed r161492: <http://trac.webkit.org/changeset/161492>
Note You need to log in before you can comment on or make changes to this bug.