Bug 126579

Summary:

AX: Make roleValue() return DescriptionListRole for <dl> elements

Product:

WebKit

Reporter:

Mario Sanchez Prada <mario>

Component:

Accessibility

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, jcraig, jdiggs, samuel_white, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch proposal	cfleizach: review+

Description Mario Sanchez Prada 2014-01-07 06:37:29 PST

At the moment, roleValue() returns ListRole for every list element, even <dl> ones and so we need to check the result of isDescriptionList() in places where we want to know if it's a normal list or a description list (e.g. the ATK wrapper).

This bug is about fixing that small issue, according to the comments on bug 125857.

Comment 1 Radar WebKit Bug Importer 2014-01-07 06:38:17 PST

<rdar://problem/15762003>

Comment 2 Mario Sanchez Prada 2014-01-07 07:15:46 PST

Created attachment 220523 [details]
Patch proposal

Attaching patch proposal.

In the end, I think no change is needed in the Mac since the code to map DescriptionListRole into NSAccessibilityListRole in role(), and the code to return NSAccessibilityDescriptionListSubrole/NSAccessibilityDefinitionListSubrole  is already there and should keep working fine.

Comment 3 Mario Sanchez Prada 2014-01-08 02:54:51 PST

Committed r161492: <http://trac.webkit.org/changeset/161492>