Bug 126578

Summary: Fix compilation issue with GLES2 after http://webkit.org/b/126548
Product: WebKit Reporter: Pascal Jacquemart <p.jacquemart>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, boxerlee, bw80.lee, commit-queue, gyuyoung.kim, gyuyoung.kim, jonlee, laszlo.gombos, mbaker, ossy, peavo, roger_fong
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Adding GLES include
bfulgham: review+, commit-queue: commit-queue-
Adding GLES include 2 none

Description Pascal Jacquemart 2014-01-07 06:22:12 PST
Missing include ;-{
Comment 1 Pascal Jacquemart 2014-01-07 06:27:02 PST
Created attachment 220520 [details]
Adding GLES include

Simply adding GLES2/gl2.h include 
Beware such include is not present in OpenGLESShims.h
Comment 2 Brent Fulgham 2014-01-07 07:44:49 PST
Comment on attachment 220520 [details]
Adding GLES include

Sorry!
Comment 3 WebKit Commit Bot 2014-01-07 07:46:01 PST
Comment on attachment 220520 [details]
Adding GLES include

Rejecting attachment 220520 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 220520, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.

Full output: http://webkit-queues.appspot.com/results/6347019723472896
Comment 4 Pascal Jacquemart 2014-01-07 08:23:44 PST
Created attachment 220530 [details]
Adding GLES include 2

Updated bug number
Comment 5 Brent Fulgham 2014-01-07 08:58:38 PST
Comment on attachment 220530 [details]
Adding GLES include 2

r=me.
Comment 6 WebKit Commit Bot 2014-01-07 09:31:04 PST
Comment on attachment 220530 [details]
Adding GLES include 2

Clearing flags on attachment: 220530

Committed r161428: <http://trac.webkit.org/changeset/161428>
Comment 7 peavo 2014-01-07 09:45:38 PST
*** Bug 126581 has been marked as a duplicate of this bug. ***