Bug 126578

Summary:

Fix compilation issue with GLES2 after http://webkit.org/b/126548

Product:

WebKit

Reporter:

Pascal Jacquemart <p.jacquemart>

Component:

Platform

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, boxerlee, bw80.lee, commit-queue, gyuyoung.kim, gyuyoung.kim, jonlee, laszlo.gombos, mbaker, ossy, peavo, roger_fong

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Adding GLES include	bfulgham: review+, commit-queue: commit-queue-
Adding GLES include 2	none

Pascal Jacquemart

Reported 2014-01-07 06:22:12 PST

Missing include ;-{

Attachments
Adding GLES include (1.08 KB, patch) 2014-01-07 06:27 PST, Pascal Jacquemart	bfulgham: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
Adding GLES include 2 (1.10 KB, patch) 2014-01-07 08:23 PST, Pascal Jacquemart	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Pascal Jacquemart

Comment 1 2014-01-07 06:27:02 PST

Created attachment 220520 [details] Adding GLES include Simply adding GLES2/gl2.h include Beware such include is not present in OpenGLESShims.h

Brent Fulgham

Comment 2 2014-01-07 07:44:49 PST

Comment on attachment 220520 [details] Adding GLES include Sorry!

WebKit Commit Bot

Comment 3 2014-01-07 07:46:01 PST

Comment on attachment 220520 [details] Adding GLES include Rejecting attachment 220520 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 220520, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Full output: http://webkit-queues.appspot.com/results/6347019723472896

Pascal Jacquemart

Comment 4 2014-01-07 08:23:44 PST

Created attachment 220530 [details] Adding GLES include 2 Updated bug number

Brent Fulgham

Comment 5 2014-01-07 08:58:38 PST

Comment on attachment 220530 [details] Adding GLES include 2 r=me.

WebKit Commit Bot

Comment 6 2014-01-07 09:31:04 PST

Comment on attachment 220530 [details] Adding GLES include 2 Clearing flags on attachment: 220530 Committed r161428: <http://trac.webkit.org/changeset/161428>

peavo

Comment 7 2014-01-07 09:45:38 PST

*** Bug 126581 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.