Bug 126563

Summary:

SetLocal for a FlushedArguments should not claim that the dataFormat is DataFormatJS

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, commit-queue, ggaren, mark.lam, mhahnenberg, msaboff, oliver, rniwa, sam

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
the patch	none

Description Filip Pizlo 2014-01-06 22:25:46 PST

Patch forthcoming.  Reduced test case:

function foo(o) {
    var a = arguments;
    var result = o.f;
    for (var i = 1; i < a.length; ++i)
        result += a[i];
    return result;
}

noInline(foo);

for (var i = 0; i < 100; ++i)
    print(foo({f:42}, 1, 2, 3));

print(foo({g:40, f:41}, 1, 2.5, 3));

<rdar://problem/15757534>

Comment 1 Filip Pizlo 2014-01-06 22:29:13 PST

Created attachment 220493 [details]
the patch

Comment 2 Ryosuke Niwa 2014-01-06 22:55:15 PST

<rdar://problem/15757534>

Comment 3 WebKit Commit Bot 2014-01-07 00:18:10 PST

Comment on attachment 220493 [details]
the patch

Clearing flags on attachment: 220493

Committed r161411: <http://trac.webkit.org/changeset/161411>

Comment 4 WebKit Commit Bot 2014-01-07 00:18:12 PST

All reviewed patches have been landed.  Closing bug.