Bug 126560

Summary:

[Mac] Fix incorrectness in use of some AppKit enums

Product:

WebKit

Reporter:

Mark Rowe (bdash) <mrowe>

Component:

Tools / Tests

Assignee:

Mark Rowe (bdash) <mrowe>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Mark Rowe (bdash) 2014-01-06 19:09:09 PST

There are places in DumpRenderTree and WebKitTestRunner where we work with AppKit enums incorrectly. We do a switch over NSScrollerPart but only handle one case, and we pass an integer to a function that expects NSBackingStoreType without a cast.

Comment 1 Mark Rowe (bdash) 2014-01-06 19:13:36 PST

Created attachment 220482 [details]
Patch

Comment 2 WebKit Commit Bot 2014-01-06 19:56:37 PST

Comment on attachment 220482 [details]
Patch

Clearing flags on attachment: 220482

Committed r161396: <http://trac.webkit.org/changeset/161396>

Comment 3 WebKit Commit Bot 2014-01-06 19:56:38 PST

All reviewed patches have been landed.  Closing bug.