Bug 126560

Summary: [Mac] Fix incorrectness in use of some AppKit enums
Product: WebKit Reporter: Mark Rowe (bdash) <mrowe>
Component: Tools / TestsAssignee: Mark Rowe (bdash) <mrowe>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Mark Rowe (bdash)
Reported 2014-01-06 19:09:09 PST
There are places in DumpRenderTree and WebKitTestRunner where we work with AppKit enums incorrectly. We do a switch over NSScrollerPart but only handle one case, and we pass an integer to a function that expects NSBackingStoreType without a cast.
Attachments
Patch (4.16 KB, patch)
2014-01-06 19:13 PST, Mark Rowe (bdash) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Rowe (bdash)
Comment 1 2014-01-06 19:13:36 PST
Created attachment 220482 [details] Patch
WebKit Commit Bot
Comment 2 2014-01-06 19:56:37 PST
Comment on attachment 220482 [details] Patch Clearing flags on attachment: 220482 Committed r161396: <http://trac.webkit.org/changeset/161396>
WebKit Commit Bot
Comment 3 2014-01-06 19:56:38 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.