Bug 126533

Summary: Change Page, FocusController to use ViewState
Product: WebKit Reporter: Gavin Barraclough <barraclough>
Component: WebKit2Assignee: Gavin Barraclough <barraclough>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, rniwa
Priority: P2    
Version: 525.x (Safari 3.1)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 127366    
Bug Blocks:    
Attachments:
Description Flags
Fix
none
Style fix
thorton: review+
for EWS
buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion
none
For EWS
none
Same patch, seg fault in make, wtf? none

Gavin Barraclough
Reported 2014-01-06 12:03:06 PST
These classes currently maintain a set of separate fields to represent the view state; combine these into a single field, and allow WebPage to send the combined update rather than individual changes. Maintain existing interface for WebKit1 clients.
Attachments
Fix (22.27 KB, patch)
2014-01-06 12:15 PST, Gavin Barraclough 		no flags
DetailsFormatted DiffDiff
Style fix (22.27 KB, patch)
2014-01-06 12:22 PST, Gavin Barraclough 		thorton: review+
DetailsFormatted DiffDiff
for EWS (24.98 KB, patch)
2014-01-23 12:02 PST, Gavin Barraclough 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion (626.53 KB, application/zip)
2014-01-23 12:54 PST, Build Bot 		no flags
Details
For EWS (24.34 KB, patch)
2014-02-05 18:35 PST, Gavin Barraclough 		no flags
DetailsFormatted DiffDiff
Same patch, seg fault in make, wtf? (24.39 KB, patch)
2014-02-05 21:53 PST, Gavin Barraclough 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2014-01-06 12:15:15 PST
Created attachment 220447 [details] Fix
WebKit Commit Bot
Comment 2 2014-01-06 12:17:58 PST
Attachment 220447 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/page/FocusController.cpp', u'Source/WebCore/page/FocusController.h', u'Source/WebCore/page/Page.cpp', u'Source/WebCore/page/Page.h', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/WebPage/WebPage.cpp', u'Source/WebKit2/WebProcess/WebPage/WebPage.h', '--commit-queue']" exit_code: 1 ERROR: Source/WebCore/page/Page.h:35: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Gavin Barraclough
Comment 3 2014-01-06 12:22:02 PST
Created attachment 220448 [details] Style fix
Gavin Barraclough
Comment 4 2014-01-09 17:34:18 PST
Committed revision 161609.
Gavin Barraclough
Comment 5 2014-01-21 10:59:00 PST
Rolled out in revision 162107. Re-landed in revision 162452.
WebKit Commit Bot
Comment 6 2014-01-21 12:59:30 PST
Re-opened since this is blocked by bug 127366
Gavin Barraclough
Comment 7 2014-01-23 12:02:57 PST
Created attachment 222010 [details] for EWS
Build Bot
Comment 8 2014-01-23 12:54:17 PST
Comment on attachment 222010 [details] for EWS Attachment 222010 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5339127599857664 New failing tests: fast/events/page-visibility-iframe-move-test.html fast/events/page-visibility-iframe-propagation-test.html fast/events/page-visibility-iframe-delete-test.html
Build Bot
Comment 9 2014-01-23 12:54:18 PST
Created attachment 222020 [details] Archive of layout-test-results from webkit-ews-06 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-06 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Gavin Barraclough
Comment 10 2014-02-05 18:35:11 PST
Created attachment 223287 [details] For EWS
Gavin Barraclough
Comment 11 2014-02-05 21:53:42 PST
Created attachment 223305 [details] Same patch, seg fault in make, wtf?
Gavin Barraclough
Comment 12 2014-02-06 00:18:37 PST
Transmitting file data ........... Committed revision 163524.
Note You need to log in before you can comment on or make changes to this bug.