build.webkit.org/dashboard should still function if localStorage is disabled

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Tim Horton]

Right now, the dashboard completely fails to load if localStorage is run-time disabled or not built into the browser.

[Tim Horton]

Created attachment 220416 [details]
patch

[Alexey Proskuryakov]

Comment on attachment 220416 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220416&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:44
> +            console.log("Couldn't use localStorage, settings won't work: " + e);

Can we hide the gear icon if it's not going to work anyway? Or is this warning incorrect, and it will work, just not persistently?

[Tim Horton]

Created attachment 220441 [details]
patch that hides the gear

[Alexey Proskuryakov]

Comment on attachment 220441 [details]
patch that hides the gear

View in context: https://bugs.webkit.org/attachment.cgi?id=220441&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:45
> +        try {
> +            localStorage.setItem(key, JSON.stringify(value));
> +        } catch(e) {
> +            console.log("Couldn't use localStorage, settings won't work: " + e);
> +        }

Do we need this try/catch now? Seems helpful to have breakage clearly visible.

[Tim Horton]

http://trac.webkit.org/changeset/161360