Bug 126511

Summary: build.webkit.org/dashboard should still function if localStorage is disabled
Product: WebKit Reporter: Tim Horton <thorton>
Component: Tools / TestsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, timothy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch that hides the gear ap: review+

Tim Horton
Reported 2014-01-05 23:33:00 PST
Right now, the dashboard completely fails to load if localStorage is run-time disabled or not built into the browser.
Attachments
patch (1.84 KB, patch)
2014-01-05 23:43 PST, Tim Horton
no flags
patch that hides the gear (3.54 KB, patch)
2014-01-06 11:07 PST, Tim Horton
ap: review+
Tim Horton
Comment 1 2014-01-05 23:43:13 PST
Alexey Proskuryakov
Comment 2 2014-01-06 08:43:59 PST
Comment on attachment 220416 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=220416&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:44 > + console.log("Couldn't use localStorage, settings won't work: " + e); Can we hide the gear icon if it's not going to work anyway? Or is this warning incorrect, and it will work, just not persistently?
Tim Horton
Comment 3 2014-01-06 11:07:04 PST
Created attachment 220441 [details] patch that hides the gear
Alexey Proskuryakov
Comment 4 2014-01-06 11:59:55 PST
Comment on attachment 220441 [details] patch that hides the gear View in context: https://bugs.webkit.org/attachment.cgi?id=220441&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:45 > + try { > + localStorage.setItem(key, JSON.stringify(value)); > + } catch(e) { > + console.log("Couldn't use localStorage, settings won't work: " + e); > + } Do we need this try/catch now? Seems helpful to have breakage clearly visible.
Tim Horton
Comment 5 2014-01-06 12:47:30 PST
Note You need to log in before you can comment on or make changes to this bug.