Bug 126478

Summary: CStack Branch: slowPathFor() should emit an epilogue instead of popping the callFrameRegister
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: JavaScriptCoreAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch mark.lam: review+

Michael Saboff
Reported 2014-01-03 17:45:05 PST
Before ThunkGenerators::slowPathFor() jumps to the target function, it returns the stack to the function entry state. Currently it does this using a pop(callFrameRegister). Instead it should emit a function epilogue(). This will work for architectures that have a link register that the callee will want to save in its prologue in addition to the callFrameRegister.
Attachments
Patch (1.29 KB, patch)
2014-01-03 17:51 PST, Michael Saboff 		mark.lam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2014-01-03 17:51:30 PST
Created attachment 220360 [details] Patch
Mark Lam
Comment 2 2014-01-04 05:46:31 PST
Comment on attachment 220360 [details] Patch r=me
Michael Saboff
Comment 3 2014-01-04 10:26:51 PST
Committed r161312: <http://trac.webkit.org/changeset/161312>
Note You need to log in before you can comment on or make changes to this bug.