Bug 126478

Summary:

CStack Branch: slowPathFor() should emit an epilogue instead of popping the callFrameRegister

Product:

WebKit

Reporter:

Michael Saboff <msaboff>

Component:

JavaScriptCore

Assignee:

Michael Saboff <msaboff>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	mark.lam: review+

Description Michael Saboff 2014-01-03 17:45:05 PST

Before ThunkGenerators::slowPathFor() jumps to the target function, it returns the stack to the function entry state.  Currently it does this using a pop(callFrameRegister).  Instead it should emit a function epilogue().  This will work for architectures that have a link register that the callee will want to save in its prologue in addition to the callFrameRegister.

Comment 1 Michael Saboff 2014-01-03 17:51:30 PST

Created attachment 220360 [details]
Patch

Comment 2 Mark Lam 2014-01-04 05:46:31 PST

Comment on attachment 220360 [details]
Patch

r=me

Comment 3 Michael Saboff 2014-01-04 10:26:51 PST

Committed r161312: <http://trac.webkit.org/changeset/161312>